From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org, Kelly Dean <kellydeanch@yahoo.com>
Subject: Re: Outline and org-mode don't insert text into folded sections logically
Date: Wed, 2 Nov 2011 13:53:48 +0100 [thread overview]
Message-ID: <85DD63EE-538B-4ADC-A40A-1880FC040C59@gmail.com> (raw)
In-Reply-To: <87aa8eu34y.fsf@altern.org>
On Nov 2, 2011, at 11:10 AM, Bastien wrote:
> Hi Carsten,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> please find enclosed a patch which is my proposal for rounding
>> off this feature.
>
> thanks for the clean implementation.
>
> There is a small typo: the second (let ...) should be (let* ...),
> see attached updated patch.
OK, I will take a look at it and then push.
>
>> It introduces a variable, applies the check to org-delete-char
>> and org-delete-backward-char, and removes the (sit-for 1),
>> and it never moves the cursor.
>
> Okay. It also applies the check for `org-self-insert-command'.
>
> I like the variable's name.
>
> Nitpicking:
>
> - (setq org-catch-invisible-edits 'show-and-error) is the same than
> (setq org-catch-invisible-edits t), right? Can we document this
> somewhere, so that users know what to expect from setting the variable
> to t?
Will do.
>
> - From the docstring: "[...] or add in the middle or right after an
> invisible region" -- I agree inserting while in the middle of the
> invisible region would feel too unpredictable, but I'd argue that
> inserting *right after* the invisible region when point is at the end
> of it feels okay. Nevermind, maybe this request will come up later,
> I'm fine with your current solution.
I tried, and it confused the hell out of me... :D
>
>> I have been unsing it for a day or two, and I like the `smart'
>> setting of the variable. Even though, I do agree with your
>> earlier post that the default should be nil.
>
> Okay. Please feel free to apply a patch when you want.
>
> Thanks!
Cheers
- Carsten
>
> <checking-for-invisible-edits_bzg.patch>
> --
> Bastien
- Carsten
next prev parent reply other threads:[~2011-11-02 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 19:14 Outline and org-mode don't insert text into folded sections logically Kelly Dean
2011-09-05 7:52 ` Giovanni Ridolfi
2011-09-05 8:01 ` suvayu ali
2011-10-22 10:13 ` Bastien
2011-10-22 10:17 ` suvayu ali
2011-10-22 10:21 ` Jambunathan K
2011-10-22 13:53 ` Bastien
2011-10-23 2:18 ` suvayu ali
2011-10-29 14:10 ` Bastien
2011-10-29 14:57 ` suvayu ali
2011-10-29 15:40 ` Bastien
2011-10-29 15:53 ` suvayu ali
2011-10-29 16:15 ` Bastien
2011-10-29 16:22 ` suvayu ali
2011-10-30 1:07 ` Bastien
2011-10-30 6:28 ` Carsten Dominik
2011-10-30 7:30 ` Jambunathan K
2011-10-30 7:47 ` Carsten Dominik
2011-10-30 9:04 ` Bastien
2011-10-30 15:37 ` Carsten Dominik
2011-10-31 20:58 ` Carsten Dominik
2011-11-02 7:12 ` Carsten Dominik
2011-11-02 10:10 ` Bastien
2011-11-02 12:53 ` Carsten Dominik [this message]
2011-11-03 1:30 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85DD63EE-538B-4ADC-A40A-1880FC040C59@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=kellydeanch@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).