From: Nick Dokos <nicholas.dokos@hp.com>
To: Luke Crook <luke@balooga.com>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Re: Using babel to generate a commit log
Date: Wed, 30 Mar 2011 09:43:16 -0400 [thread overview]
Message-ID: <8526.1301492596@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Luke Crook <luke@balooga.com> of "Wed, 30 Mar 2011 07:57:03 -0000." <loom.20110330T095343-141@post.gmane.org>
Luke Crook <luke@balooga.com> wrote:
> Jambunathan K <kjambunathan <at> gmail.com> writes:
>
> >
> > Luke Crook <luke <at> balooga.com> writes:
> >
> > > 2) I have to add at delay of at least 5 seconds (set-for 5 t) as vc-git
> calls
> > > "git log" as an asynchronous process. If not for the delay then babel
> > > immediately returns an empty buffer and the "vc-call-backend" process never
> > > completes.
> > >
> > > Is there a better way that I can accomplish (2) ?
> >
> > Quick hints if you are willing to settle for some hacks.
> >
> > In vc-do-command, you may have to set OKSTATUS to 0. Track
> > `vc-disable-async-diff' in vc.el and vc-svn.el for possible hints.
> >
>
> I changed my code to wait until the 'Git' process completes. Luckily "vc-call-
> backend" returns the async process.
>
Oh, I missed that - thanks for pointing it out.
> #+begin_src emacs-lisp :var limit="" :file test.log :exports results
> ;; Most of this code is copied from vc.el vc-print-log
> (when (vc-find-backend-function (vc-backend (buffer-file-name (current-buffer)))
> 'print-log)
> (let* ((limit (if (numberp limit) limit vc-log-show-limit))
> (vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
> (backend (car vc-fileset))
> (files (cadr vc-fileset)))
> (with-temp-buffer
> (let ((status (vc-call-backend backend
> 'print-log
> files
> (current-buffer))))
> (while (not (eq 'exit (process-status status)))
> (sit-for 1 t))
> (buffer-string)))))
> #+end_src
>
... or you could use a sentinel :-)
One bit of defensive programming might be to check that status *is* a
process before you do the wait: vc-do-command returns a real status in
the synchronous case, so if you cut-n-paste this code with some other
command that does not use async, it'll blow up.
Nick
next prev parent reply other threads:[~2011-03-30 13:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 5:38 Using babel to generate a commit log Luke Crook
2011-03-30 6:26 ` Jambunathan K
2011-03-30 7:57 ` Luke Crook
2011-03-30 13:43 ` Nick Dokos [this message]
2011-03-30 18:08 ` Luke Crook
2011-03-30 18:42 ` Nick Dokos
2011-03-30 6:28 ` Suvayu Ali
2011-03-30 7:52 ` Luke Crook
2011-03-30 13:07 ` Nick Dokos
2011-03-30 15:34 ` Luke Crook
2011-03-30 16:51 ` Nick Dokos
2011-03-30 17:47 ` Luke Crook
2011-03-30 18:41 ` Luke Crook
2011-03-30 20:10 ` Eric Schulte
2011-03-30 20:22 ` Nick Dokos
2011-03-30 22:02 ` Luke Crook
2011-03-30 23:20 ` Luke Crook
2011-03-30 23:44 ` Eric Schulte
2011-03-31 6:49 ` Luke Crook
2011-04-01 0:28 ` Eric Schulte
2011-03-30 6:29 ` Nick Dokos
2011-03-30 20:12 ` Eric Schulte
2011-03-30 21:58 ` Luke Crook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8526.1301492596@alphaville.dokosmarshall.org \
--to=nicholas.dokos@hp.com \
--cc=emacs-orgmode@gnu.org \
--cc=luke@balooga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).