emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Marco Wahl <marcowahlsoft@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Survey: changing a few default settings for Org 9.4
Date: Wed, 19 Feb 2020 18:57:49 +0100	[thread overview]
Message-ID: <84y2sypihu.fsf@gmail.com> (raw)
In-Reply-To: <87r1yq3ddy.fsf@gnu.org> (Bastien's message of "Wed, 19 Feb 2020 14:39:05 +0100")

Hi Bastien and all,

>> Subject: [PATCH 1/2] org: Fix corner case for org-kill-line
>>
>> * lisp/org.el (org-kill-line): Kill _all_ tags when the cursor is on the tags part.
>
> There is a problem with this patch: when on a empty heading with tags,
> killing the tags will let the cursor back right after the last "*".
> Not a big deal in most headlines, but when on the first headline, this
> leads to an error.

Okay.  Thanks for this finding.

> I think org-kill-line should not try to do too much, and kill only
> parts of the tags when the cursor is in the middle of tags is the
> right thing to do.

Fair enough.  I tried to implement the sentence "When after the headline
text, kill the tags" from the documentation for org-special-ctrl-k,
which I interpreted as kill _all_ tags.  Just to make clear my decision
for the patch.

> As for the other patch, I think it's important to explain that the
> whole subtree will be killed, even if not visible -- that's the whole
> point of this variable after all.

AFAICS the kill of a folded (invisible) subtree is also performed
without having set org-special-ctrl-k.  So I'd rather say that there is
no need for pointing out that behavior in the documentation.

> So I'm sorry but these patches can't make it.
>
> Thanks anyway!

You are welcome.  That's fine with me.


Ciao!

  reply	other threads:[~2020-02-19 17:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  7:39 Survey: changing a few default settings for Org 9.4 Bastien
2020-02-19  8:57 ` Samuel Wales
2020-02-19  9:01   ` Bastien
2020-02-19 20:02   ` Samuel Wales
2020-02-19 20:15     ` Marcin Borkowski
2020-02-19 21:35       ` Bastien
2020-02-19 22:06         ` Samuel Wales
2020-02-19 11:03 ` Marco Wahl
2020-02-19 11:41   ` Bastien
2020-02-19 13:21     ` Marco Wahl
2020-02-19 13:39       ` Bastien
2020-02-19 17:57         ` Marco Wahl [this message]
2020-02-19 20:44           ` Bastien
2020-02-20  4:11       ` Adam Porter
2020-02-19 11:30 ` Nicolas Goaziou
2020-02-19 11:57   ` Bastien
2020-02-19 14:07     ` Nicolas Goaziou
2020-02-19 17:24       ` Bastien
2020-02-19 23:23         ` Vladimir Lomov
2020-02-19 23:53           ` Bastien
2020-02-20  0:20             ` Samuel Wales
2020-02-19 12:58   ` Tim Cross
2020-02-19 13:22     ` Bastien
2020-02-19 15:06       ` Tim Cross
2020-02-19 13:03   ` AW
2020-02-19 15:41 ` Matthew Lundin
2020-02-19 16:16   ` Joost Kremers
2020-02-19 17:13     ` Bastien
2020-02-19 16:50   ` Detlef Steuer
2020-02-19 17:14     ` Bastien
2020-02-20  4:07 ` Adam Porter
2020-02-20  7:10   ` Bastien
2020-02-20 14:10     ` Kaushal Modi
2020-02-21 15:49 ` Bastien
2020-02-21 19:36   ` Diego Zamboni
2020-02-21 21:28     ` Archenoth
2020-02-22  9:38       ` Bastien
2020-02-22 12:45         ` Nicolas Goaziou
2020-02-22 13:31           ` Bastien
2020-02-22 18:57           ` Archenoth
2020-03-18  2:20 ` Mark E. Shoulson
2020-03-18  8:58   ` Norman Tovey-Walsh
2020-03-18 20:47     ` Hiding emphasis markers Mark E. Shoulson
2020-05-22 16:47       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84y2sypihu.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).