From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Wahl <marcowahlsoft@gmail.com>
Subject: Re: point moves and zoom level reverts when refreshing agenda
Date: Sun, 24 Jun 2018 10:15:01 +0200
Message-ID: <84vaa88ut6.fsf@gmail.com>
References: <CAJcAo8vFByyp3yQHSzNtEHzUMNO4WuW6McV==+=1mu7Pq=M6dg@mail.gmail.com>
	<84vab61lf3.fsf@gmail.com> <841sdlco5v.fsf@gmail.com>
	<CAJcAo8tLm_Y2tzPNnucByNxs11VOTyBhS__PV4d7VqCn5TUAkQ@mail.gmail.com>
	<84r2llas45.fsf@gmail.com> <87fu1ieivj.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1fX0B3-00082F-Ap
	for emacs-orgmode@gnu.org; Sun, 24 Jun 2018 04:15:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1fX0Az-0008WC-V1
	for emacs-orgmode@gnu.org; Sun, 24 Jun 2018 04:15:17 -0400
Received: from [195.159.176.226] (port=58954 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>)
	id 1fX0Az-0008U9-5j
	for emacs-orgmode@gnu.org; Sun, 24 Jun 2018 04:15:13 -0400
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1fX08n-00078K-Tj
	for emacs-orgmode@gnu.org; Sun, 24 Jun 2018 10:12:57 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Bonjour!

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Thank you. It looks good. Feel free to apply it.

Thanks, I did.

> I have two suggestions however:
>
> 1. There is some code duplication, e.g., (dolist ...), could this be
>    factored out before applying the patch?

Yes, done, thanks for the hint.  The patch has been committed.

> 2. Would it make sense to add the variables to preserve in a dedicated
>    top-level variable instead of burying them in the code?

I don't know.  Possibly this is a YAGNI.  A top-level variable could be
introduced any time.  Further someone might come up with a freshly
rewritten agenda in the meantime. ;)

BTW: It might be a good idea to take ideas from `list-buffers' and
friends for the rewrite of the agenda.


Ciao,
     Marco