From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl Subject: Re: Cannot display local images with orgmode under macOS Date: Mon, 18 Nov 2019 22:58:48 +0100 Message-ID: <84tv70vobr.fsf@gmail.com> References: <84lfutel4g.fsf@gmail.com> <87h832o3wf.fsf@gmail.com> <874kz2nmdz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41024) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWp2r-0006yG-0X for emacs-orgmode@gnu.org; Mon, 18 Nov 2019 16:58:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWp2q-00028W-1A for emacs-orgmode@gnu.org; Mon, 18 Nov 2019 16:58:52 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:35434) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWp2p-000288-PA for emacs-orgmode@gnu.org; Mon, 18 Nov 2019 16:58:51 -0500 Received: by mail-wm1-x329.google.com with SMTP id 8so1094356wmo.0 for ; Mon, 18 Nov 2019 13:58:51 -0800 (PST) In-Reply-To: <874kz2nmdz.fsf@gmail.com> (Jack Kamm's message of "Sun, 17 Nov 2019 14:55:36 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: emacs-orgmode@gnu.org Jack Kamm writes: > I've attached a patch which I believe fixes the issue. Thanks. > The problem appears to be that, when imagemagick is installed and the > image width is unset, that the image will be created by an elisp > expression like > > (create-file "some/image.png" 'imagemagick nil :width nil) > > which doesn't work, maybe because imagemagick tries to create a 0-width > image. > > The attached patch reverts to the old behavior of only using imagemagick > when width is non-nil, fixing the bug introduced by 48da60f47. Your patch is on the branches master and next now. I added the word TINYCHANGE to your commit message. Ciao