emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Cannot display local images with orgmode under macOS
Date: Mon, 18 Nov 2019 22:58:48 +0100	[thread overview]
Message-ID: <84tv70vobr.fsf@gmail.com> (raw)
In-Reply-To: <874kz2nmdz.fsf@gmail.com> (Jack Kamm's message of "Sun, 17 Nov 2019 14:55:36 -0800")

Jack Kamm <jackkamm@gmail.com> writes:

> I've attached a patch which I believe fixes the issue.

Thanks.

> The problem appears to be that, when imagemagick is installed and the
> image width is unset, that the image will be created by an elisp
> expression like
>
> (create-file "some/image.png" 'imagemagick nil :width nil)
>
> which doesn't work, maybe because imagemagick tries to create a 0-width
> image.
>
> The attached patch reverts to the old behavior of only using imagemagick
> when width is non-nil, fixing the bug introduced by 48da60f47.

Your patch is on the branches master and next now.  I added the word
TINYCHANGE to your commit message.


Ciao

      reply	other threads:[~2019-11-18 21:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  2:33 Cannot display local images with orgmode under macOS Zhengyu Duan
2019-09-12 12:48 ` Marco Wahl
2019-09-12 17:02   ` Berry, Charles
2019-09-13  4:37     ` Tim Cross
2019-09-14  7:43       ` Marco Wahl
2019-09-27 10:30         ` Zhengyu Duan
2019-09-27 16:27           ` Marco Wahl
2019-09-13 11:50   ` Rick Frankel
2019-11-17 16:37   ` Jack Kamm
2019-11-17 22:55     ` Jack Kamm
2019-11-18 21:58       ` Marco Wahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84tv70vobr.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jackkamm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).