emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Marco Wahl <marcowahlsoft@gmail.com>
To: Yu Han Quek <qythium@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]
Date: Mon, 30 Mar 2020 23:38:37 +0200	[thread overview]
Message-ID: <84eet9bk0y.fsf@gmail.com> (raw)
In-Reply-To: <CAGCUw0iAc9UQTGbgGzmBijKtNVSDt5QRYsF0auBo9fMm9ODf0w@mail.gmail.com> (Yu Han Quek's message of "Tue, 31 Mar 2020 00:04:50 +0800")

Yu Han Quek <qythium@gmail.com> writes:

> Calling org-table-insert-column in a table with formulas wrongly increments
> the column number left of the newly inserted column.
>
> Minimal example:
>
> | 1 | 2 | 3 |
>
> #+TBLFM: $3=$1+$2
>
> With cursor in the `1` cell, call `M-x org-table-insert-column`.
>
> Expected output:
>
> | 1 |   | 2 | 3 |
>
> #+TBLFM: $4=$1+$3
>
> Actual output ($1 wrongly changed to $2):
>
> | 1 |   | 2 | 3 |
>
> #+TBLFM: $4=$2+$3
>
> The bug seems to be in the last 2 lines of the
> function org-table-insert-column:
>
>       (org-table-fix-formulas "$" nil (1- col) 1)
>       (org-table-fix-formulas "$LR" nil (1- col) 1)
>
> Changing `(1- col)` to `col` solves the issue.

Thanks.  I committed your fix with the TINYCHANGE marker.

I find it slightly suspicious that the documentation says

#v+
‘M-S-<RIGHT>’ (‘org-table-insert-column’)
     Insert a new column to the left of point position.
#v-

But actually the new column goes to the right and this is also fused by
the tests.  Has there been a stealth shift to the right?  Anyway, I
guess the documentation text should be updated as well.

Any objections or comments about this?


Ciao,
-- Marco

next prev parent reply	other threads:[~2020-03-30 21:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 16:04 Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)] Yu Han Quek
2020-03-30 21:38 ` Marco Wahl [this message]
2020-03-30 23:22   ` Kyle Meyer
2020-03-31 10:29     ` Eric S Fraga
2020-03-31 14:05       ` Nicolas Goaziou
2020-03-31 14:35         ` Julius Dittmar
2020-03-31 14:54         ` Eric S Fraga
2020-03-31 20:09           ` Nicolas Goaziou
2020-04-01 10:49             ` Marco Wahl
2020-04-01 13:24               ` Nicolas Goaziou
2020-04-01 14:12             ` Carsten Dominik
2020-04-01 17:51               ` Marco Wahl
2020-04-01 18:54                 ` Carsten Dominik
2020-04-17 17:44                   ` Marco Wahl
2020-04-17 17:58                     ` Nicolas Goaziou
2020-04-17 22:51                       ` Marco Wahl
2020-04-18 11:23                         ` Eric S Fraga
2020-04-18 14:30                           ` Marco Wahl
2020-04-20  8:21                             ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84eet9bk0y.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=qythium@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).