emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Cc: Andrea <agiugliano91@gmail.com>
Subject: Re: Bug: org-eww-copy-for-org-mode Empty Link problem + easy fix [9.0.4 (9.0.4-elpaplus @ /home/andrea/.emacs.d/elpa/org-plus-contrib-20170124/)]
Date: Sun, 12 Feb 2017 09:27:57 +0100	[thread overview]
Message-ID: <848tpb6cfm.fsf@tm6592> (raw)
In-Reply-To: 87k28w7l6y.fsf@gmail.com

Hello Andrea,

thanks for your bug report and your suggestion to fix the bug.

[...]

> The error is due to the presence of input forms (e.g., in
> www.indeed.co.uk where you can add the job you are looking for), that
> are considered like urls by this function [1]. When the input form is
> passed to org-make-link-string, org-make-link-string complains that the
> link is empty.
>
> Now I solved this by adding an if statement that makes the link only if
> the info passed is not nil [2], but maybe someone knows a better check
> for org-eww-goto-next-url-property-change than the one using 'shr-url?

I committed a fix to maint and master.  Concretely I simplified your
code to essentially one additional if case.

You are referenced in the commit-message as reporter.


Best regards,

                       Marco

     prev parent reply	other threads:[~2017-02-12  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11 16:21 Bug: org-eww-copy-for-org-mode Empty Link problem + easy fix [9.0.4 (9.0.4-elpaplus @ /home/andrea/.emacs.d/elpa/org-plus-contrib-20170124/)] Andrea
2017-02-12  8:27 ` Marco Wahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848tpb6cfm.fsf@tm6592 \
    --to=marcowahlsoft@gmail.com \
    --cc=agiugliano91@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).