From: Marco Wahl <marcowahlsoft@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [rfc] org-dired
Date: Wed, 15 Nov 2017 14:54:28 +0100 [thread overview]
Message-ID: <841skzhckr.fsf@gmail.com> (raw)
In-Reply-To: 8760abzs8y.fsf@nicolasgoaziou.fr
Hi!
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> I just pushed the functionality to master.
>
>
> Thank you.
>
> However, I didn't have time to comment the code.
>
> There are a few stylistic issues:
>
> `mapc' + `lambda' -> `dolist' in `org-attach-attach-files'.
Done.
> However, I think `org-attach-attach-files' can be removed, since it is
> called only once and is really two lines long. IOW, please include it in
> `org-attach-dired-attach-to-next-best-subtree'.
Done.
> "no window in Org-mode" -> "No window displaying an Org buffer"
Done.
> I don't think it is useful to implement
> `org-attach-dired-attach-to-next-best-subtree-mv'. I assume that once
> `org-attach-method' is set, a user is unlikely to change it for a single
> command. IOW, let's just implement
> `org-attach-dired-attach-to-next-best-subtree'.
Done.
> Nitpick: an inline comment uses a single semicolon.
Okay.
> It would also be better to shorten function names, e.g.
>
> org-attach-dired-attach-to-next-best-subtree -> org-attach-dired-to-subtree
Done.
> There are also a few issues in "test-org-attach.el".
>
> For example `touch' uses the wrong name-space. Besides, it is not
> useful.
Removed.
> We usually do
>
> (org-test-with-temp-text-in-file
> "... Org bufer..."
> (let ((filename (buffer-file-name)))
> ...))
Okay.
> It would be best to refactor
> `test-org-attach/dired-attach-to-next-best-subtree/1' so that `should'
> is the outer sexp. The cleanup part should probably be in an
> `unwind-protect'. Not that it is not useful if
> °org-test-with-temp-text-in-file'.
I followed you suggestions and I think the new version is cleaner.
Thank you!
Marco
next prev parent reply other threads:[~2017-11-15 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 15:17 [rfc] org-dired Marco Wahl
2017-11-12 16:38 ` Nicolas Goaziou
2017-11-12 17:53 ` Marco Wahl
2017-11-15 11:07 ` Marco Wahl
2017-11-15 11:38 ` Nicolas Goaziou
2017-11-15 13:54 ` Marco Wahl [this message]
2017-11-21 22:48 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841skzhckr.fsf@gmail.com \
--to=marcowahlsoft@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).