From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: iota@whxvd.name, 65734@debbugs.gnu.org, emacs-orgmode@gnu.org
Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]
Date: Thu, 07 Sep 2023 13:19:48 +0300 [thread overview]
Message-ID: <83il8mz3nf.fsf@gnu.org> (raw)
In-Reply-To: <87pm2upajy.fsf@localhost> (message from Ihor Radchenko on Thu, 07 Sep 2023 10:00:49 +0000)
> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: iota@whxvd.name, 65734@debbugs.gnu.org, emacs-orgmode@gnu.org
> Date: Thu, 07 Sep 2023 10:00:49 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Then perhaps just a special value for buffer-invisibility-spec, or
> > some other simple variation of a property Org already uses?
>
> We may have a misunderstanding here.
> In "* Heading text :tag1:tag2:", everything is visible yet Org needs to
> protect ":tag1:tag2: from being killed by `kill-line', but not from
> `kill-whole-line'. Moreover, the behaviour also depends on the point
> position - if point is inside ":tag1:tag2:", we fall back to the default
> behaviour. And the whole "special" behaviour can also be switched off by
> flipping `org-special-ctrl-k'.
>
> Invisibility has nothing to do with this need.
Isn't it true that invisibility is what causes the user expectations
in this case to begin with? Then saying that "invisibility has
nothing to do with this" is not really accurate, is it?
> >> What about something like `end-of-visible-line-function'?
> >
> > That is also a possibility, but it will then affect kill-line
> > _anywhere_ in the buffer, whereas a text property can have a more
> > localized effect. Are you sure kill-line will need this customization
> > on the whole buffer?
>
> Applying text property is not free - (1) we need to do it across the
> whole buffer, which scales poorly; (2) we need to keep it updated as the
> buffer changes, which scales even worse. In addition, adding more text
> properties slow down redisplay, which Org already strains to its limits.
I understand, but in my book correctness tramps performance, and I was
trying to make the point that perhaps modifying the behavior of
kill-line everywhere in Org buffers might be incorrect for some cases.
next prev parent reply other threads:[~2023-09-07 10:20 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 16:30 [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Sebastian Miele
2023-09-05 10:29 ` Ihor Radchenko
2023-09-05 11:54 ` bug#65734: " Eli Zaretskii
2023-09-05 15:25 ` Sebastian Miele
2023-09-05 15:50 ` Eli Zaretskii
2023-09-06 8:23 ` Ihor Radchenko
2023-09-06 12:16 ` Eli Zaretskii
2023-09-06 13:30 ` Sebastian Miele
2023-09-07 13:49 ` Ihor Radchenko
2023-09-06 8:30 ` Ihor Radchenko
2023-09-06 12:20 ` Eli Zaretskii
2023-09-07 10:00 ` Ihor Radchenko
2023-09-07 10:19 ` Eli Zaretskii [this message]
2023-09-07 10:27 ` Sebastian Miele
2023-09-07 13:43 ` Ihor Radchenko
2023-09-06 15:04 ` Sebastian Miele
2023-09-07 10:03 ` Ihor Radchenko
2023-09-05 14:30 ` Max Nikulin
2023-09-05 15:42 ` Eli Zaretskii
2023-09-05 15:50 ` Ihor Radchenko
2023-09-05 16:02 ` Max Nikulin
2023-09-05 16:12 ` Ihor Radchenko
2023-09-05 16:14 ` Eli Zaretskii
2024-01-07 16:27 ` Stefan Monnier
2024-01-08 12:15 ` Ihor Radchenko
2024-01-08 15:33 ` Stefan Monnier
2024-01-09 14:52 ` Ihor Radchenko
2024-01-09 16:48 ` Stefan Monnier
2024-01-09 22:21 ` Ihor Radchenko
2024-01-09 15:47 ` Ihor Radchenko
2024-01-09 16:01 ` Stefan Monnier
2024-01-09 22:33 ` Ihor Radchenko
2024-01-10 3:08 ` Stefan Monnier
2024-01-10 12:52 ` Eli Zaretskii
2024-01-10 13:05 ` Ihor Radchenko
2024-01-10 13:55 ` Eli Zaretskii
2024-01-11 15:50 ` Ihor Radchenko
2024-01-11 16:05 ` Eli Zaretskii
2024-01-11 16:15 ` Ihor Radchenko
2024-01-11 16:44 ` Eli Zaretskii
2024-01-11 18:08 ` Ihor Radchenko
2024-01-11 19:19 ` Eli Zaretskii
2024-01-12 12:24 ` Ihor Radchenko
2024-01-12 12:32 ` Eli Zaretskii
2024-01-12 12:39 ` Ihor Radchenko
2024-01-12 14:03 ` Eli Zaretskii
2024-01-12 14:15 ` Ihor Radchenko
2024-01-12 21:09 ` Stefan Monnier
2024-01-12 21:16 ` Ihor Radchenko
2024-01-10 16:26 ` Stefan Monnier
2024-01-10 16:39 ` Eli Zaretskii
2024-01-11 15:44 ` Ihor Radchenko
2024-01-09 15:50 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83il8mz3nf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65734@debbugs.gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=iota@whxvd.name \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).