emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
       [not found] <m2v8yg7uxl.fsf@gmail.com>
@ 2022-01-21  1:35 ` Kyle Meyer
  2022-01-21  2:07   ` bruce robertson
  2022-01-21  7:13 ` Eli Zaretskii
  1 sibling, 1 reply; 8+ messages in thread
From: Kyle Meyer @ 2022-01-21  1:35 UTC (permalink / raw)
  To: Bruce E. Robertson; +Cc: 53393

[ I've reassigned this bug report so that new messages will be directed
  to the Org mailing list, where it's more likely to get a reply.  In
  the future, please consider using org-submit-bug-report or sending a
  message to emacs-orgmode@gnu.org directly. ]

Bruce E. Robertson writes:

> emacs -Q test.org
> cursor to "CLOCK:" line, C-c C-c
> total time updates but day of week does not change
> contents of test.org
> ------
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> :END:
> ------
> typing C-c C-c does update total log time for line and recently did
> update the day of the week but no long does

I'm having trouble finding an Org version where it will update a
timestamp _within_ a clock line.  I tried it out with v9.1 and the day
of the week still isn't updated.  Outside of that context it will, as
org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
than taking the clock branch.

If you can provide more details about a version where it did work,
showing it's a regression, I think you'll have a higher chance of
getting this fixed.

Anyway, at least for now, perhaps you could try something like this to
get the behavior you want:

  (defun my/update-clock-and-days ()
    (when (eq (org-element-type (org-element-context)) 'clock)
      (let ((re (org-re-timestamp 'inactive)))
        (save-excursion
          (goto-char (line-beginning-position))
          (while (re-search-forward re (line-end-position) t)
            (backward-char)
            (org-timestamp-change 0 'day))))))
  
  (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)

With that, hitting `C-c C-c` on the clock line at

--8<---------------cut here---------------start------------->8---
* heading
:LOGBOOK:
CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
:END:
--8<---------------cut here---------------end--------------->8---

produces

--8<---------------cut here---------------start------------->8---
* heading
:LOGBOOK:
CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
:END:
--8<---------------cut here---------------end--------------->8---




^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
  2022-01-21  1:35 ` bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week Kyle Meyer
@ 2022-01-21  2:07   ` bruce robertson
  2022-01-22 12:22     ` Peter Davis
  0 siblings, 1 reply; 8+ messages in thread
From: bruce robertson @ 2022-01-21  2:07 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: 53393

[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]

Thanks. I’ll do that. Org-submit … that is.

On Thu, Jan 20, 2022 at 5:35 PM Kyle Meyer <kyle@kyleam.com> wrote:

> [ I've reassigned this bug report so that new messages will be directed
>   to the Org mailing list, where it's more likely to get a reply.  In
>   the future, please consider using org-submit-bug-report or sending a
>   message to emacs-orgmode@gnu.org directly. ]
>
> Bruce E. Robertson writes:
>
> > emacs -Q test.org
> > cursor to "CLOCK:" line, C-c C-c
> > total time updates but day of week does not change
> > contents of test.org
> > ------
> > * heading
> > :LOGBOOK:
> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> > :END:
> > ------
> > typing C-c C-c does update total log time for line and recently did
> > update the day of the week but no long does
>
> I'm having trouble finding an Org version where it will update a
> timestamp _within_ a clock line.  I tried it out with v9.1 and the day
> of the week still isn't updated.  Outside of that context it will, as
> org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
> than taking the clock branch.
>
> If you can provide more details about a version where it did work,
> showing it's a regression, I think you'll have a higher chance of
> getting this fixed.
>
> Anyway, at least for now, perhaps you could try something like this to
> get the behavior you want:
>
>   (defun my/update-clock-and-days ()
>     (when (eq (org-element-type (org-element-context)) 'clock)
>       (let ((re (org-re-timestamp 'inactive)))
>         (save-excursion
>           (goto-char (line-beginning-position))
>           (while (re-search-forward re (line-end-position) t)
>             (backward-char)
>             (org-timestamp-change 0 'day))))))
>
>   (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)
>
> With that, hitting `C-c C-c` on the clock line at
>
> --8<---------------cut here---------------start------------->8---
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
> :END:
> --8<---------------cut here---------------end--------------->8---
>
> produces
>
> --8<---------------cut here---------------start------------->8---
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
> :END:
> --8<---------------cut here---------------end--------------->8---
>
-- 
λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται
πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

[-- Attachment #2: Type: text/html, Size: 3562 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
       [not found] <m2v8yg7uxl.fsf@gmail.com>
  2022-01-21  1:35 ` bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week Kyle Meyer
@ 2022-01-21  7:13 ` Eli Zaretskii
  2022-01-26  5:12   ` bruce robertson
  1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-01-21  7:13 UTC (permalink / raw)
  To: Bruce E. Robertson; +Cc: 53393

> From: "Bruce E. Robertson" <brucer42@gmail.com>
> Date: Tue, 18 Jan 2022 10:36:22 -0800
> 
> 
> emacs -Q test.org
> cursor to "CLOCK:" line, C-c C-c
> total time updates but day of week does not change
> contents of test.org
> ------
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> :END:
> ------
> typing C-c C-c does update total log time for line and recently did
> update the day of the week but no long does

Isn't this an Org problem that should be reported to the Org
developers first?

Thanks.




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
  2022-01-21  2:07   ` bruce robertson
@ 2022-01-22 12:22     ` Peter Davis
  2022-01-23  3:33       ` Ihor Radchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Peter Davis @ 2022-01-22 12:22 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 2982 bytes --]

Hello,

Please unsubscribe my husband Peter Davis from this list.  He died 3 years ago.

Thanks,
Donna Cantera-Davis

On Thu, Jan 20, 2022, at 9:07 PM, bruce robertson wrote:
> Thanks. I’ll do that. Org-submit … that is. 
> 
> On Thu, Jan 20, 2022 at 5:35 PM Kyle Meyer <kyle@kyleam.com> wrote:
>> [ I've reassigned this bug report so that new messages will be directed
>>   to the Org mailing list, where it's more likely to get a reply.  In
>>   the future, please consider using org-submit-bug-report or sending a
>>   message to emacs-orgmode@gnu.org directly. ]
>> 
>> Bruce E. Robertson writes:
>> 
>> > emacs -Q test.org
>> > cursor to "CLOCK:" line, C-c C-c
>> > total time updates but day of week does not change
>> > contents of test.org
>> > ------
>> > * heading
>> > :LOGBOOK:
>> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>> > :END:
>> > ------
>> > typing C-c C-c does update total log time for line and recently did
>> > update the day of the week but no long does
>> 
>> I'm having trouble finding an Org version where it will update a
>> timestamp _within_ a clock line.  I tried it out with v9.1 and the day
>> of the week still isn't updated.  Outside of that context it will, as
>> org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
>> than taking the clock branch.
>> 
>> If you can provide more details about a version where it did work,
>> showing it's a regression, I think you'll have a higher chance of
>> getting this fixed.
>> 
>> Anyway, at least for now, perhaps you could try something like this to
>> get the behavior you want:
>> 
>>   (defun my/update-clock-and-days ()
>>     (when (eq (org-element-type (org-element-context)) 'clock)
>>       (let ((re (org-re-timestamp 'inactive)))
>>         (save-excursion
>>           (goto-char (line-beginning-position))
>>           (while (re-search-forward re (line-end-position) t)
>>             (backward-char)
>>             (org-timestamp-change 0 'day))))))
>> 
>>   (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)
>> 
>> With that, hitting `C-c C-c` on the clock line at
>> 
>> --8<---------------cut here---------------start------------->8---
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
>> :END:
>> --8<---------------cut here---------------end--------------->8---
>> 
>> produces
>> 
>> --8<---------------cut here---------------start------------->8---
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
>> :END:
>> --8<---------------cut here---------------end--------------->8---
> -- 
> λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

--
  Peter Davis
  www.techcurmudgeon.com

[-- Attachment #2: Type: text/html, Size: 5209 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
  2022-01-22 12:22     ` Peter Davis
@ 2022-01-23  3:33       ` Ihor Radchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Ihor Radchenko @ 2022-01-23  3:33 UTC (permalink / raw)
  To: Peter Davis; +Cc: emacs-orgmode

"Peter Davis" <pfd@pfdstudio.com> writes:

> Please unsubscribe my husband Peter Davis from this list.  He died 3 years ago.
>
> Thanks,
> Donna Cantera-Davis

I am sorry to hear this.

To unsubscribe, feel free to follow the steps described in
https://lists.gnu.org/mailman/listinfo/emacs-orgmode

Look for the following text at the bottom of the page:

"To unsubscribe from Emacs-orgmode, get a password reminder, or change
your subscription options enter your subscription email address:"

Best,
Ihor


^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
  2022-01-21  7:13 ` Eli Zaretskii
@ 2022-01-26  5:12   ` bruce robertson
  0 siblings, 0 replies; 8+ messages in thread
From: bruce robertson @ 2022-01-26  5:12 UTC (permalink / raw)
  To: 53393

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

FWIW, day *does* update in lines like, "SCHEDULED: <2022-01-25 Tue .+1d>".
Interestingly the timestamp is angle-bracketed rather than
square-bracketed. Hmm



On Thu, Jan 20, 2022 at 11:13 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: "Bruce E. Robertson" <brucer42@gmail.com>
> > Date: Tue, 18 Jan 2022 10:36:22 -0800
> >
> >
> > emacs -Q test.org
> > cursor to "CLOCK:" line, C-c C-c
> > total time updates but day of week does not change
> > contents of test.org
> > ------
> > * heading
> > :LOGBOOK:
> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> > :END:
> > ------
> > typing C-c C-c does update total log time for line and recently did
> > update the day of the week but no long does
>
> Isn't this an Org problem that should be reported to the Org
> developers first?
>
> Thanks.
>


-- 
λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται
πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

[-- Attachment #2: Type: text/html, Size: 1823 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
  2022-01-22  5:21 ` No Wayman
@ 2022-01-22  5:45   ` No Wayman
  0 siblings, 0 replies; 8+ messages in thread
From: No Wayman @ 2022-01-22  5:45 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: emacs-orgmode-request


It looks like the correction of the day name in timestamps is 
hardcoded in `org-ctrl-c-ctrl-c':

>	((or `timestamp (and `planning (guard (org-at-timestamp-p 
>'lax))))
>	 (org-timestamp-change 0 'day))


`org-clock-update-time-maybe' uses a regexp to match the start and 
end times and hands those off to `org-parse-time-string' which 
does not consider the day name.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week
       [not found] <mailman.67.1642784492.19950.emacs-orgmode@gnu.org>
@ 2022-01-22  5:21 ` No Wayman
  2022-01-22  5:45   ` No Wayman
  0 siblings, 1 reply; 8+ messages in thread
From: No Wayman @ 2022-01-22  5:21 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: emacs-orgmode-request


>> From: "Bruce E. Robertson" <brucer42@gmail.com>
>> Date: Tue, 18 Jan 2022 10:36:22 -0800
>> 
>> 
>> emacs -Q test.org
>> cursor to "CLOCK:" line, C-c C-c
>> total time updates but day of week does not change
>> contents of test.org
>> ------
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>> :END:
>> ------
>> typing C-c C-c does update total log time for line and recently 
>> did
>> update the day of the week but no long does

Confirmed:

Yodel[1] Report 2022-01-22 00:19:18
===================================

--8<---------------cut here---------------start------------->8---
(yodel
  :save "org-bug"
  :packages* org
  :post*
  (yodel-file "org-bug-test"
    :point "|"
    :with*
    "* heading"
    " :LOGBOOK:"
    " CLOCK: | [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29]"
    " :END:" :then*
    (require 'org-clock)
    (org-clock-update-time-maybe)
    (print (buffer-string))))
--8<---------------cut here---------------end--------------->8---

STDOUT
======

> Loading /tmp/org-bug/straight-bootstrap-snippet.el (source)...

> "* heading
>  :LOGBOOK:
>  CLOCK:  [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>  :END:"

Environment
===========

- emacs version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, 
  GTK+ Version 3.24.31, cairo version 1.17.4)
 of 2022-01-13
- system type: gnu/linux

Packages
========

- org 
  https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=846226a202619866fe80667d13e9d5a105bd1eef

[1] https://www.github.com/progfolio/yodel


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-01-26  5:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <m2v8yg7uxl.fsf@gmail.com>
2022-01-21  1:35 ` bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week Kyle Meyer
2022-01-21  2:07   ` bruce robertson
2022-01-22 12:22     ` Peter Davis
2022-01-23  3:33       ` Ihor Radchenko
2022-01-21  7:13 ` Eli Zaretskii
2022-01-26  5:12   ` bruce robertson
     [not found] <mailman.67.1642784492.19950.emacs-orgmode@gnu.org>
2022-01-22  5:21 ` No Wayman
2022-01-22  5:45   ` No Wayman

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).