From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giovanni Ridolfi Subject: Re: Re: [PATCH] org: rework property set Date: Tue, 14 Dec 2010 11:15:57 +0100 Message-ID: <8362uwirs2.fsf@yahoo.it> References: <1292261368-28538-1-git-send-email-julien@danjou.info> <87d3p5xtap.fsf@norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=54139 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PSRub-0001aP-55 for emacs-orgmode@gnu.org; Tue, 14 Dec 2010 05:15:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PSRuZ-0000zg-Pt for emacs-orgmode@gnu.org; Tue, 14 Dec 2010 05:15:13 -0500 Received: from nm18-vm0.bullet.mail.ukl.yahoo.com ([217.146.183.95]:20798) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PSRuZ-0000zc-Dv for emacs-orgmode@gnu.org; Tue, 14 Dec 2010 05:15:11 -0500 In-Reply-To: (Julien Danjou's message of "Tue, 14 Dec 2010 10:01:16 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: Julien Danjou , emacs-orgmode@gnu.org Julien Danjou writes: > On Mon, Dec 13 2010, Bernt Hansen wrote: > >> This patch format is better. Could you put the comments like 'I may >> have done this badly, ...' and 'It works but there maybe some corners >> case ...' after the --- and before the diffstat? > > Sure, this is how I did usually, but last time I did that IIRC and > Carsten asked me to resend the patch with my text in the commit message. > Hi, Julien, > So please someone really tell me what I should do ! :-) It should be described here: Commit messages and ChangeLog entries on http://orgmode.org/worg/org-contribute.php [1] Unfortunately it seems to be down, I hope you have cloned worg ;-) You can see also: http://lists.gnu.org/archive/html/emacs-orgmode/2010-07/msg00037.html I think that you can put some extra, useful, information, that can go in the Changelog, as lines not beginning with "*". But if you write very unformal/personal comments like: 'I may have done this badly, ...' you should write after the ---. cheers, Giovanni [1] thanks to David, http://lists.gnu.org/archive/html/emacs-orgmode/2010-09/msg01512.html