From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Panteleev Subject: Re: [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments Date: Wed, 14 Mar 2018 14:03:56 +0000 Message-ID: <8258182a-5d7e-d8c9-96c2-1a76dd9e143c@gmail.com> References: <20180307225847.24068-1-git@thecybershadow.net> <20180307225847.24068-2-git@thecybershadow.net> <87muzcans9.fsf@nicolasgoaziou.fr> <9107300b-c95d-ad16-ca03-088d173c90d9@gmail.com> <87605yn4x3.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ew70f-000478-JC for emacs-orgmode@gnu.org; Wed, 14 Mar 2018 10:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ew70a-0001Bp-Vh for emacs-orgmode@gnu.org; Wed, 14 Mar 2018 10:04:05 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:40752) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ew70a-0001BS-OD for emacs-orgmode@gnu.org; Wed, 14 Mar 2018 10:04:00 -0400 Received: by mail-wm0-x22e.google.com with SMTP id t6so4301422wmt.5 for ; Wed, 14 Mar 2018 07:04:00 -0700 (PDT) In-Reply-To: <87605yn4x3.fsf@nicolasgoaziou.fr> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org, Vladimir Panteleev Hi, On 2018-03-14 13:49, Nicolas Goaziou wrote: > Vladimir Panteleev writes: >> I agree that it is strange. I mentioned it (and its strangeness) in >> the cover-letter. The documentation of org-sbe describes it as well. > > AFAICT, it doesn't. "org-sbe" describes a dollar _prefix_, but yours > stands on its own. It prefixes nothing. I wrote about this in the cover letter too. $"foo" and $ "foo" are both the same thing. In both cases, they are two distinct lisp tokens. The way $ is presented as a string/reference "prefix" is through convention only. Or are you objecting on stylistic grounds, that the test case from my patch doesn't follow the convention of omitting whitespace after the $ token, thus making it look like a prefix? This is, of course, subjective, but I would prefer to not perpetuate the illusion that $"foo" is some magical Emacs Lisp language syntax for a new kind of string literal, at least in the test suite. > Also, it seems to apply only to > cell's references, whereas your example provides a strings which is > clearly not a reference. I'm confused. The references are substituted with string literals before the $-prefix handling occurs. This is why it doesn't work with ranges. I agree that it is all very confusing, and there is a lot of room for improvement. That doesn't stand in the way of this patch series, though. > What happens if you use (org-sbe "identity" (x ...)) instead? No difference. As can be seen from org-sbe's implementation, the normalization of symbols and string literals occurs before attempting to resolve references. -- Best regards, Vladimir