emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Richard Stanton <stanton@haas.berkeley.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Question on latex source block
Date: Sun, 09 Sep 2012 03:07:12 -0400	[thread overview]
Message-ID: <8243.1347174432@alphaville> (raw)
In-Reply-To: Message from Richard Stanton <stanton@haas.berkeley.edu> of "Sat, 08 Sep 2012 22:15:10 PDT." <40C7B1BFC291ED4E9D10436D07736A3347089E653C@EXMAIL7.haas.uc.berkeley.edu>

Richard Stanton <stanton@haas.berkeley.edu> wrote:

> Using Org-mode version 7.9.1 (release_7.9.1-154-g659be3 @ c:/emacs/site-lis=
> p/org-mode/lisp/), I created the following LaTeX code block:
> 
> #+begin_src latex :file test.png
> \frac{1}{2}
> #+end_src
> 
> When I press C-c C-c to compile the code block, I get the following error d=
> ump:
> 
> Debugger entered--Lisp error: (void-function org-create-formula-image)
>   org-create-formula-image("\\frac{1}{2}" "test.png" (:foreground default :=
> background default :scale 1.0 :html-foreground "Black" :html-background "Tr=
> ansparent" :html-scale 1.0 :matchers ("begin" "$1" "$" "$$" "\\(" "\\[")) t=
> )
>   org-babel-execute:latex("\\frac{1}{2}" ((:comments . "") (:shebang . "") =
> (:cache . "no") (:padline . "") (:noweb . "no") (:tangle . "no") (:exports =
> . "results") (:results . "file replace latex") (:session . "none") (:hlines=
>  . "no") (:padnewline . "yes") (:file . "test.png") (:result-type . value) =
> (:result-params "file" "replace" "latex") (:rowname-names) (:colname-names)=
> ))
>   org-babel-execute-src-block(nil ("latex" "\\frac{1}{2}" ((:comments . "")=
>  (:shebang . "") (:cache . "no") (:padline . "") (:noweb . "no") (:tangle .=
>  "no") (:exports . "results") (:results . "file replace latex") (:session .=
>  "none") (:hlines . "no") (:padnewline . "yes") (:file . "test.png") (:resu=
> lt-type . value) (:result-params "file" "replace" "latex") (:rowname-names)=
>  (:colname-names)) "" nil 0))
>   org-babel-execute-src-block-maybe()
>   org-babel-execute-maybe()
>   org-babel-execute-safely-maybe()
>   run-hook-with-args-until-success(org-babel-execute-safely-maybe)
>   org-ctrl-c-ctrl-c(nil)
>   call-interactively(org-ctrl-c-ctrl-c nil nil)
> 
> What am I missing here?
> 

Nothing - it's a bug introduced by commit a9d3ce0bcd3492eb0cd2aa7b0d1f6ee93276114b:

,----
| commit a9d3ce0bcd3492eb0cd2aa7b0d1f6ee93276114b
| Author: Feng Shu <tumashu@gmail.com>
| Date:   Fri Apr 20 19:21:43 2012 +0200
| 
|     Allow to use imagemagick for previewing LaTeX fragements.
|     
|     * org.el (org-latex-create-formula-image-program): New option
|     to use either dvipng or imagemagick to convert and preview
|     LaTeX fragments.
|     (org-preview-latex-fragment, org-format-latex): Handle the new
|     option.
|     (org-create-formula-image-with-dvipng): Rename from
|     `org-create-formula-image'.
|     (org-create-formula-image-with-imagemagick): New defun to
|     handle LaTeX preview with imagemagick.
|     (org-latex-color, org-latex-color-format): New defuns to
|     handle color conversions.
|     
|     * org-latex.el (org-latex-to-pdf-process, org-export-as-pdf):
|     Allow to use imagemagick to convert LaTeX fragments.
|     
|     * org-html.el (org-export-html-preprocess): Ditto.
|     
|     * org-exp.el (org-export-with-LaTeX-fragments): Ditto.
|     
|     * org.texi (@LaTeX{} fragments): Document imagemagick as an
|     alternative to dvipng.
| 
`----

org-create-formula-image got renamed, but the reference in ob-latex.el
to the original name was not changed.

The quick-and-dirty "fix" is to change the reference in ob-latex.el to
org-create-formula-image-dvipng or org-create-formula-image-imagemagick,
depending on which method you happen to be using. But one would resort
to that only in the direst emergency in order to get something working
as quickly as possible.

IMO, it would be better to have split the dvipng/imagemagick decision at
a lower level in the code. That way, both org-format-latex and
org-babel-execute:latex would use the common function. As it is,
org-format-latex is a fairly "dirty" function and with the split, it got
even dirtier.

But there may be difficulties that my quick glance through the code has
not uncovered: it needs a deeper look.

Nick

  reply	other threads:[~2012-09-09  7:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09  5:15 Question on latex source block Richard Stanton
2012-09-09  7:07 ` Nick Dokos [this message]
2012-09-09  7:17   ` Nick Dokos
2012-09-09 16:49   ` Eric Schulte
2012-09-09 17:44     ` Nick Dokos
2012-09-09 19:39       ` Eric Schulte
2012-09-09 20:31         ` Nick Dokos
2012-09-13  6:00         ` Jambunathan K
2012-09-13  7:28           ` Nick Dokos
2012-09-13  7:58             ` Nick Dokos
2012-09-13 15:07           ` Eric Schulte
2012-09-13 16:04             ` Nick Dokos
2012-09-13 17:09               ` Eric Schulte
2012-09-13 19:12                 ` Abdó Roig-Maranges
2012-09-13 19:42                   ` Jambunathan K
2012-09-14  7:27                     ` Bastien
     [not found] <mailman.113.1347292828.2054.emacs-orgmode@gnu.org>
2012-09-10 16:49 ` Richard Stanton
2012-09-10 19:07   ` Nick Dokos
2012-09-10 20:43     ` Richard Stanton
2012-09-10 20:53       ` Nick Dokos
2012-09-11  6:52         ` Giovanni Ridolfi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8243.1347174432@alphaville \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=stanton@haas.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).