emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jambunathan K <kjambunathan@gmail.com>
To: Manuel Giraud <manuel.giraud@univ-nantes.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] * org-html.el (org-html-make-link): correct a bug in coderef link.
Date: Wed, 13 Apr 2011 00:28:34 +0530	[thread overview]
Message-ID: <81lizfcn51.fsf@gmail.com> (raw)
In-Reply-To: <1302614330-23496-1-git-send-email-manuel.giraud@univ-nantes.fr> (Manuel Giraud's message of "Tue, 12 Apr 2011 15:18:50 +0200")


Quick feedback. 

Applied the patch to my workarea. My example (which was stolen from
Orgmode manual) gets exported just fine.

Jambunathan K.

Manuel Giraud <manuel.giraud@univ-nantes.fr> writes:

> ---
>  lisp/org-html.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 58fbc05..5d53478 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -826,7 +826,8 @@ MAY-INLINE-P allows inlining it as an image."
>  		(not type)
>  		(string= type "http")
>  		(string= type "https")
> -		(string= type "file"))
> +		(string= type "file")
> +		(string= type "coderef"))
>  	       (if fragment
>  		  (setq thefile (concat thefile "#" fragment))))
>  
> @@ -836,7 +837,8 @@ MAY-INLINE-P allows inlining it as an image."
>  	 (setq thefile
>  	    (let
>  	       ((str (org-export-html-format-href thefile)))
> -	      (if (and type (not (string= "file" type)))
> +	      (if (and type (not (or (string= "file" type)
> +				     (string= "coderef" type))))
>  		  (concat type ":" str)
>  		  str)))

-- 

  reply	other threads:[~2011-04-12 18:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 12:01 [BUG] HTML Export/Broken coderef links? Jambunathan K
2011-04-12 13:18 ` [PATCH] * org-html.el (org-html-make-link): correct a bug in coderef link Manuel Giraud
2011-04-12 18:58   ` Jambunathan K [this message]
2011-04-15 11:58   ` [Accepted] " Carsten Dominik
2011-04-13  9:20 ` [BUG] HTML Export/Broken coderef links? Aankhen
2011-04-13  9:23   ` Aankhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81lizfcn51.fsf@gmail.com \
    --to=kjambunathan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=manuel.giraud@univ-nantes.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).