From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: [PATCH: RESUBMITTED] Fix broken CUSTOM_ID links Date: Wed, 17 Nov 2010 20:52:51 +0530 Message-ID: <817hgcnfec.fsf_-_@gmail.com> References: <81mxpnwtah.fsf@gmail.com> <43EFAC24-FD29-4565-AB08-0C6F2AF6CBA5@gmail.com> <81oca0rl2h.fsf_-_@gmail.com> <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com> <69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from [140.186.70.92] (port=52571 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIjqy-0001Y8-CE for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 10:23:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIjqw-0004Xe-9n for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 10:23:20 -0500 Received: from mail-pz0-f41.google.com ([209.85.210.41]:37084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIjqv-0004XH-Oa for emacs-orgmode@gnu.org; Wed, 17 Nov 2010 10:23:18 -0500 Received: by pzk30 with SMTP id 30so312441pzk.0 for ; Wed, 17 Nov 2010 07:23:17 -0800 (PST) In-Reply-To: <69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com> (Carsten Dominik's message of "Wed, 17 Nov 2010 14:26:08 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --=-=-= Carsten >> this looks good, However, I would like you to make a change to the >> patch more more clarity. >> >> Could you please write >> >> (or preferred target) >> >> instead of >> >> remove >> >> as the ID to be inserted? Even though these are the same, the first >> version is a lot clearer. >> >> With this change, I will accept the patch. I have made the modifications requested by you. Reproducing the original report for the sake of record. Jambunathan K. # Bug Description: Note the 'H:1' option. Search for 'broken' in the # the below org file. #+OPTIONS: H:1 * Links ** Targets *** Fuzzy Target One Two Three Four Five *** Target with CUSTOMID :PROPERTIES: :CUSTOM_ID: aabbccddeeff :END: One Two Three Four Five *** Dedicated Target # <> One Two Three Four Five *** <<>> One Two Three Four Five ** References *** References to Fuzzy Target This is a link to [[Fuzzy Target]]. *** References to CUSTOMID links This link to [[#aabbccddeeff][CUSTOMID Target]] is broken. *** References to Dedicated Target There is a link to nodesc [[Dedicated Target]] here. There is a link to [[Dedicated%20Target][Jump to Dedicated Target]] here. *** References to Radioed Links This section has references to Radioed Target. One more reference to Radioed Target. Verification: bash-3.2$ diff -pub customid-before.html customid-after.html --- customid-before.html 2010-11-17 20:36:20.140625000 +0530 +++ customid-after.html 2010-11-17 20:39:45.234375000 +0530 @@ -1,3 +1,4 @@ + customid - + @@ -100,7 +101,7 @@
    -
  • Target with CUSTOMID
    +
  • Target with CUSTOMID

    One @@ -199,7 +200,7 @@

    Author: Jambunathan K <kjambunathan@gmail.com>

    -

    Date: 2010-11-17 20:35:58

    +

    Date: 2010-11-17 20:39:11

    HTML generated by org-mode 7.3 in emacs 23

    Attachments: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-Fix-broken-CUSTOM_ID-links-to-outline-levels-exporte.patch Content-Description: customid.patch >From 896a97a00c28206a940bb935406c60f19db3de15 Mon Sep 17 00:00:00 2001 From: Jambunathan K Date: Mon, 8 Nov 2010 18:33:29 +0530 Subject: [PATCH 2/2] Fix broken CUSTOM_ID links to outline levels exported as lists. (org-html-level-start): Modified. TINYCHANGE. --- lisp/org-html.el | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) mode change 100644 => 100755 lisp/org-html.el diff --git a/lisp/org-html.el b/lisp/org-html.el old mode 100644 new mode 100755 index 68fee5b..2aea978 --- a/lisp/org-html.el +++ b/lisp/org-html.el @@ -2358,12 +2358,12 @@ When TITLE is nil, just close all open levels." (progn (org-close-li) (if target - (insert (format "
  • " target) extra-targets title "
    \n") + (insert (format "
  • " remove) extra-targets title "
    \n") (insert "
  • " title "
    \n"))) (aset org-levels-open (1- level) t) (org-close-par-maybe) (if target - (insert (format "
      \n
    • " target) + (insert (format "
        \n
      • " remove) extra-targets title "
        \n") (insert "
          \n
        • " title "
          \n")))) (aset org-levels-open (1- level) t) -- 1.7.2.3 --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --=-=-=--