From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Re: Location of OpenDocument style files should be configurable Date: Thu, 29 Dec 2011 21:36:18 +0530 Message-ID: <8162gzpdl1.fsf@gmail.com> References: <20220.19946.360761.625682@a1i15.kph.uni-mainz.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:51188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIVC-0006OT-Bb for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 11:06:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgIVA-0005OA-V0 for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 11:06:46 -0500 Received: from mail-gx0-f169.google.com ([209.85.161.169]:64957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIVA-0005O5-Ow for emacs-orgmode@gnu.org; Thu, 29 Dec 2011 11:06:44 -0500 Received: by ggni2 with SMTP id i2so10190763ggn.0 for ; Thu, 29 Dec 2011 08:06:44 -0800 (PST) In-Reply-To: <20220.19946.360761.625682@a1i15.kph.uni-mainz.de> (Ulrich Mueller's message of "Thu, 29 Dec 2011 12:24:26 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ulrich Mueller Cc: bzg@altern.org, seb@debian.org, emacs-orgmode@gnu.org, davemarq@us.ibm.com Hello Ulrich > Hi, > In Gentoo we have an issue with the location of the OpenDocument style > files, reported to us in bug 396269 [1]. Makefile in org-7.8.02 is buggy and breaks the ODT exporter. Bastien, is likely to re-publish a version of org-7.8.x soon. Lately, there has been some confusion around how and where OpenDocument style files go. There have also been multiple bug reports surrounding broken export. > When org-mode is installed as a separate Gentoo package, its lisp > files are installed in /usr/share/emacs/site-lisp/org-mode/. > According to our policy, non-lisp files would go to > /usr/share/emacs/etc/org-mode/. We would pass this as the "etcdir" > parameter to "make install", so the odt style files would be installed > in stylesdir = /usr/share/emacs/etc/org-mode/styles/. Org-7.8.x has been accepted in to Emacs-24.1 [1]. I have proposed that the style files go as "c:/Program Files/emacs-24.0.92/etc/org/*.xml" [2]. Note that under stock Emacs, the org package go under "org" subdir. (locate-library "org.elc") => "c:/Program Files/emacs-24.0.92/lisp/org/org.elc" So, will it be acceptable, if org-odt.el searches for styles file under /../../etc/org/. (For vanilla Emacs, this is same as `data-directory'/etc/org. See C-h v data-directory) This way the package structure under gentoo will parallel the structure under stock Emacs. I am copying Sebastien (the debian maintainer) and Dave (who fixed the Makefile subsequent to 7.8.02) release. If there is consensus, I will fix org-odt.el and also Makefile. Side Note: I am little bit hesitant to make org-odt-styles-dir a defcustom. Already there are defcustoms for org-export-odt-styles-file and org-export-odt-content-template-file and making org-odt-styles-dir will add needless confusion to the users. Jambunathan K. Footnotes: [1] http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00607.html [2] http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00571.html > Now org-odt.el currently defines org-odt-styles-dir in a defconst, > and it searches only in ../etc/styles/, ./etc/styles/, and ./etc/org/ > relative to lispdir. Obviously it cannot find the files in the Gentoo > location. > > Now my question, could the defconst be changed to a defvar, so that we > can specify the location in our site-start file? Or, preferably, could > the etcdir specified in "make" command be honoured in the lisp code? > > Ulrich > > [1] > > --