2012-04-05 Sebastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> * org-table.el (org-table-iterate-buffer-tables): Autoload function. From 8bf259dea1d84dede8c193c2e8d8223a6e5e87ec Mon Sep 17 00:00:00 2001 From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org> Date: Thu, 5 Apr 2012 16:22:44 +0200 Subject: [PATCH] Add autoload cookie for function org-table-iterate-buffer-tables --- lisp/org-table.el | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lisp/org-table.el b/lisp/org-table.el index c336f89..8dd449a 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -2963,6 +2963,7 @@ with the prefix ARG." (widen) (org-table-map-tables (lambda () (org-table-recalculate t)) t)))) +;;;###autoload (defun org-table-iterate-buffer-tables () "Iterate all tables in the buffer, to converge inter-table dependencies." (interactive) -- 1.7.9 Best regards, Seb -- Sebastien Vauban
Hi Sébastien,
"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
> 2012-04-05 Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
>
> * org-table.el (org-table-iterate-buffer-tables): Autoload
> function.
Why do you need this function to be autoloaded?
Thanks,
--
Bastien
Hi Bastien,
Bastien wrote:
> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>> 2012-04-05 Sebastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
>>
>> * org-table.el (org-table-iterate-buffer-tables): Autoload
>> function.
>
> Why do you need this function to be autoloaded?
To be able to use it in batch mode without having to require explicitly
`org-table'.
Best regards,
Seb
--
Sebastien Vauban
Hi Sébastien,
"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
> Hi Bastien,
>
> Bastien wrote:
>> "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
>>> 2012-04-05 Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
>>>
>>> * org-table.el (org-table-iterate-buffer-tables): Autoload
>>> function.
>>
>> Why do you need this function to be autoloaded?
>
> To be able to use it in batch mode without having to require explicitly
> `org-table'.
The problem is there are quite a lot of commands (interactive functions)
that can be used in batch mode. Why adding autoload to this and not to
another one?
I don't want to open the door for one-by-one requests of this kind...
so unless this is a more pressing need for an autoload cookie, I'll let
you (require 'org-table) in your script.
Does that make sense?
--
Bastien
Hi Bastien,
Bastien wrote:
> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>> Bastien wrote:
>>> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>>>> 2012-04-05 Sebastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
>>>>
>>>> * org-table.el (org-table-iterate-buffer-tables): Autoload
>>>> function.
>>>
>>> Why do you need this function to be autoloaded?
>>
>> To be able to use it in batch mode without having to require explicitly
>> `org-table'.
>
> The problem is there are quite a lot of commands (interactive functions)
> that can be used in batch mode. Why adding autoload to this and not to
> another one?
>
> I don't want to open the door for one-by-one requests of this kind... so
> unless this is a more pressing need for an autoload cookie, I'll let you
> (require 'org-table) in your script.
>
> Does that make sense?
I'd be more in favor of trying to get autoload cookies for all the functions
which could need it, hence accepting such one-by-one patches -- which have no
border effects of any sort.
For example, you accepted the autoload cookie on org-version, a couple of
weeks ago.
But, OK, there is certainly not right or wrong position, so I respect yours.
Best regards,
Seb
--
Sebastien Vauban
Hi Sébastien, "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes: > For example, you accepted the autoload cookie on org-version, a couple of > weeks ago. Because it seems quite obvious why people would need to check org-version in batch mode. > But, OK, there is certainly not right or wrong position, so I respect > yours. The core idea of my answer was this: please make a complete list of commands that should be autoloaded then submit a single patch for this. Deciding one by one is definitely too time-consuming. Thanks for your help in this area, -- Bastien
Hi Sébastien,
"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
> 2012-04-05 Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
>
> * org-table.el (org-table-iterate-buffer-tables): Autoload
> function.
I finally accepted this in master. I reviewed org-table.el for other
candidates and found `org-table-recalculate-buffer-tables', which is
also autoloaded now.
Thanks for bringing this up,
--
Bastien
Hi Bastien, Bastien wrote: > "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes: >> >> * org-table.el (org-table-iterate-buffer-tables): Autoload >> function. > > I finally accepted this in master. I reviewed org-table.el for other > candidates and found `org-table-recalculate-buffer-tables', which is also > autoloaded now. I confirm the patch is OK. Thanks. > Thanks for bringing this up, In the same vein, I found `org-update-all-dblocks', for which I propose a patch hereafter. I've scanned the 121 occurrences of `(interactive)' in `org.el' to look for extra potential candidates to the autoloading, but did not find any useful ones. Hence, just this one to add: From 3df73c03d9a8c56189cbe91ec752bcc3269536ca Mon Sep 17 00:00:00 2001 From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org> Date: Wed, 18 Apr 2012 11:12:00 +0200 Subject: [PATCH 3/3] Add autoload cookie for org-update-all-dblocks 2012-04-18 Sebastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> * org.el (org-update-all-dblocks): Autoload function. --- lisp/org.el | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 170ddc9..5473a20 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -11075,6 +11075,7 @@ Error if there is no such block at point." (goto-char pos) (error "Not in a dynamic block")))) +;;;###autoload (defun org-update-all-dblocks () "Update all dynamic blocks in the buffer. This function can be used in a hook." -- 1.7.9 Best regards, Seb -- Sebastien Vauban
Hi Sébastien, "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes: > In the same vein, I found `org-update-all-dblocks', for which I propose a > patch hereafter. Applied against master, thanks. > I've scanned the 121 occurrences of `(interactive)' in `org.el' to look for > extra potential candidates to the autoloading, but did not find any useful > ones. Hence, just this one to add: Thanks for the thorough check! >From 3df73c03d9a8c56189cbe91ec752bcc3269536ca Mon Sep 17 00:00:00 2001 > From: Sebastien Vauban <sva@mygooglest.com> > Date: Wed, 18 Apr 2012 11:12:00 +0200 > Subject: [PATCH 3/3] Add autoload cookie for org-update-all-dblocks > > 2012-04-18 Sebastien Vauban <wxhgmqzgwmuf@spammotel.com> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ You don't need to add the line above in your ChangeLog entry. > * org.el (org-update-all-dblocks): Autoload function. Thanks, -- Bastien
Hi Bastien,
Bastien wrote:
> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>
>> In the same vein, I found `org-update-all-dblocks', for which I propose a
>> patch hereafter.
>
> Applied against master, thanks.
>
>> [...]
>
>> From 3df73c03d9a8c56189cbe91ec752bcc3269536ca Mon Sep 17 00:00:00 2001
>> From: Sebastien Vauban <sva-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
>> Date: Wed, 18 Apr 2012 11:12:00 +0200
>> Subject: [PATCH 3/3] Add autoload cookie for org-update-all-dblocks
>>
>> * org.el (org-update-all-dblocks): Autoload function.
When checking the status of some patches I provided, I just noticed that
the function `org-update-all-dblocks' is NOT autoloaded anymore.
Can you put the autoload cookie back? Thanks.
Best regards,
Seb
--
Sebastien Vauban
Hi Sébastien,
"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:
> When checking the status of some patches I provided, I just noticed that
> the function `org-update-all-dblocks' is NOT autoloaded anymore.
>
> Can you put the autoload cookie back? Thanks.
Why is it necessary?
--
Bastien