Re: [BABEL] Two minor issues

From: "Sébastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [BABEL] Two minor issues
Date: Mon, 22 Nov 2010 21:14:51 +0100	[thread overview]
Message-ID: <80r5edw1xg.fsf@missioncriticalit.com> (raw)
In-Reply-To: 877hg5qw2x.fsf@gmail.com

Hi Dan,

Dan Davison wrote:
> S=C3=A9bastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw-XMD5yJDbdMRS5n6/RkiaJA@public.gmane.orgne.org>
> writes:
> Could you tell me what I should do with the random characters in the
> addresses that appear in your emails?

I think it's the "encryption" done by Gmane, isn't it?  Do you currently have
a problem with them?  I did not change anything, though.

> I've deleted the addresses and just sending to emacs-orgmode-mXXj517/zsQ@public.gmane.org, is
> that OK?

I always received your mails directly to my inbox up to now, so no need to
change your procedure. Anyway, I'm reading thru the newsgroup, so I should
always see your answers there as well.

>> Dan Davison wrote:
>>> S=C3=A9bastien Vauban writes:
>>>> Dan Davison wrote:
>
> <...>
>
>> Honestly, the way I update that code has been mainly done by sequences of
>> trials and errors. The above code is, for me, still quite complex to
>> understand with vars such as beg, beg1, end, end1 for which I hadn't
>> completely understood the meaning.
>
> This seems to work -- could you try it out?

Perfect for me!  Thanks a lot...

> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/org.el b/lisp/org.el
> index e2de48e..0b082da 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5102,9 +5102,6 @@ will be prompted for."
>  	      (add-text-properties
>  	       beg end
>  	       '(font-lock-fontified t font-lock-multiline t))
> -	      (add-text-properties beg beg1 '(face org-meta-line))
> -	      (add-text-properties end1 (+ end 1) '(face org-meta-line))
> -					; for end_src
>  	      (cond
>  	       ((and lang org-src-fontify-natively)
>  		(org-src-font-lock-fontify-block lang block-start block-end))
> @@ -5117,6 +5114,8 @@ will be prompted for."
>  		(add-text-properties beg1 end1 '(face org-quote)))
>  	       ((string=3D block-type "verse")
>  		(add-text-properties beg1 end1 '(face org-verse))))
> +	      (add-text-properties beg beg1 '(face org-meta-line))
> +	      (add-text-properties (1+ end) (1+ end1) '(face org-meta-line))
>  	      t))
>  	   ((member dc1 '("title:" "author:" "email:" "date:"))
>  	    (add-text-properties
> --8<---------------cut here---------------end--------------->8---

The only remaining problem (even tinier -- maybe not to find, but for the
Orger) is: when in native fontification, the open parenthesis of the =setq=
line (second line of the last code block) is wrongly fontified.

But that was there before your patch. So, unrelated...

Would you, though, have an idea how to introduce a background color for the
source block part, I'd take it. If not, its status stays, for me, SOMEDAY ;-)

Thanks a lot for your contrib.

Best regards,
  Seb

-- 
Sébastien Vauban

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode-mXXj517/zsQ@public.gmane.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode