From: "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [babel] Some variables with no default value don't provoke an error
Date: Fri, 16 Sep 2011 21:54:29 +0200 [thread overview]
Message-ID: <80fwjwgt56.fsf@somewhere.org> (raw)
In-Reply-To: 87ty8cpjk2.fsf@gmail.com
Hi Eric,
Eric Schulte wrote:
> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>> Eric Schulte wrote:
>>> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>>>> Weirdly enough, in the following code block, I must add a default value for
>>>> vars `table', `column' and `type' but not for the var `nullability'.
>>>>
>>>> I've even been able to add fake vars `something' and `else' with no error
>>>> being reported (at ingestion time):
>>>>
>>>> #+srcname: add-column-in-table(table="", column="", something, type="", else, nullability)
>>>> #+begin_src sql
>>>> -- add column `$column' (if column does not exist yet)
>>>> IF NOT EXISTS (SELECT *
>>>> FROM INFORMATION_SCHEMA.COLUMNS
>>>> WHERE TABLE_NAME = '$table'
>>>> AND COLUMN_NAME = '$column')
>>>> BEGIN
>>>> ALTER TABLE $table
>>>> ADD $column $type $nullability
>>>> END
>>>> #+end_src
>>>>
>>>> Note that, in the above state, the code block is ingested with no error, but,
>>>> if I remove the default value of var `table', it then generates back an
>>>> error...
>>>
>>> I've just pushed up a check for these functional-syntax variables which
>>> will ensure that each is given a default value. Since this check takes
>>> place at the location of the code block it /does/ include the name of
>>> the code block in the error message.
>>
>> If you have a couple of minutes, can you clarify some points to be sure I can
>> understand:
>>
>> - What do you call functional-syntax vars? The ones in the #+srcname, next to
>> the block name, as opposed to the ones declared as :var arguments?
>
> yes, that's exactly it, I don't know what "functional-syntax" is a good
> or descriptive term, but it is used in the source code so I'm now
> repeating it.
OK.
>> The fact, then, that we can get a clearer message in case of error, seems to
>> me an incentive to use that type of declaration...
>
> I personally prefer the traditional ":var" style, I'll have to add
> similar error checking there...
Good to know.
>> - Why was `nullability' not detected to have no default value? Why were
>> `table', `column' and `type' well correctly detected?
>
> Meaning after you assigned values to the first three no error was thrown
> when the fourth (nullability) wasn't assigned a value? Could you
> provide a minimal example?
Yes, you summed up exactly what I (can assure you that) observed yesterday.
Though, now that the message includes the src-name, it is somehow fixed. I
can't reproduce it anymore... Thanks.
Best regards,
Seb
--
Sebastien Vauban
prev parent reply other threads:[~2011-09-16 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 9:05 [babel] Some variables with no default value don't provoke an error Sebastien Vauban
2011-09-15 15:26 ` Eric Schulte
2011-09-16 9:42 ` Sebastien Vauban
2011-09-16 14:07 ` Eric Schulte
2011-09-16 19:54 ` Sebastien Vauban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fwjwgt56.fsf@somewhere.org \
--to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).