From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sebastien Vauban" Subject: Re: [babel] Trying to add ERT test cases Date: Tue, 20 Sep 2011 09:22:12 +0200 Message-ID: <80d3evy8yj.fsf@somewhere.org> References: <80sjnswzh5.fsf@somewhere.org> <87ty88vad1.fsf@gmail.com> <80ehzcwck0.fsf@somewhere.org> <87litkte08.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org To: emacs-orgmode-mXXj517/zsQ@public.gmane.org Hi Eric, Eric Schulte wrote: >> * Test >> >> #+begin_src emacs-lisp >> (ert-deftest ob-tangle/speed-command-r () >> "Test that speed command `r' does demote the headline." >> (org-test-at-id "4ee368b8-cf7c-4269-98c0-b28dcf94ff2b" >> (goto-char (point-at-bol)) >> (org-self-insert-command ?r) >> (goto-char (point-at-bol)) >> (should (looking-at "\\*\\* Speed command")) >> (delete-char 1))) >> #+end_src >> >> When running the test _once_, I get my level-1 headline preceded by 114 >> occurrences of ^M (yes, 114 for 1 test run!): >> >> ^M^M^M...^M^M^M* Speed command (this must be at level-1 headline) >> >> and no demotion of my headline. >> >> Do you understand such? > > So it looks like these self-insert-command functions are special cases. > They don't look to their arguments to see what key-press invoked them, > but rather they call the `this-command-keys' function for this purpose. > We can force the behavior we want by overriding the definition of this > function locally, taking this approach the following test case worked > for me > > #+begin_src emacs-lisp > (ert-deftest ob-tangle/speed-command-r () > "Test that speed command `r' does demote the headline." > (org-test-with-temp-text "* Speed command" > (flet ((this-command-keys () "r")) (org-self-insert-command ?r)) > (goto-char (point-min)) > (should (looking-at "\\*\\* Speed command")))) > #+end_src It passes! So does: #+begin_src emacs-lisp (ert-deftest ob-tangle/speed-command-r () "Test that speed command `r' does demote the headline." (org-test-with-temp-text "* Speed command" (flet ((this-command-keys () "r")) (org-self-insert-command ?a)) (goto-char (point-min)) (should (looking-at "\\*\\* Speed command")))) #+end_src where the argument of `org-self-insert-command' is `a' (could be anything, it seems). Very weird. I just understood as well why I got 114 ^M: 114 is the ASCII code for `r', and `\r' is as well ^M -- though `r' is not... >> [...] I read thru the page you link to. Just a minor thing: link to "See >> ert-publish-test.el for the implementation" is broken. >> >> Do you have a solution for checking against internal broken links? > > Nothing comes immediately to mind. > >> I still have my idea of letting DOT draw an graph of the >> interconnection between pages, so that we see missing pages, and >> unreachable ones (files on the file system, but never linked). I >> should (find the time to) extend it enough to serve that purpose. > > This could be useful, like a site map for worg. As an intermediate step > I could see it being useful to simply print out all internal links whose > target does not exist on the file system. I'll try to come up with something (in Babel) soon. Best regards, Seb -- Sebastien Vauban