emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
       [not found] <CAHZoxq8t3b7XUwt3zrh+iPYxCp9sQ-yAOrj1H2Y8UoEuB5sgVQ@mail.gmail.com>
@ 2012-03-23  0:33 ` Glenn Morris
       [not found] ` <80aa389mvi.fsf@fencepost.gnu.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2012-03-23  0:33 UTC (permalink / raw)
  To: Eric Hanchrow; +Cc: 9809

Eric Hanchrow wrote:

> I started emacs with "emacs -Q".  Then I typed
>
>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>
> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
> command flyspell-auto-correct-word".
>
> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
> flyspell-auto-correct-word.

This occurs because org.el for some reason tries to define the M-TAB key
3 different ways:

(org-defkey org-mode-map [(meta tab)] 'pcomplete)
(org-defkey org-mode-map "\M-\t" 'pcomplete)
(org-defkey org-mode-map "\M-\C-i"      'pcomplete)

Removing all but the second definition would fix this.

Ref "Named ASCII Control Characters" in the lispref.

    If you do not want to distinguish between (for example) <TAB> and
    `C-i', make just one binding, for the ASCII character <TAB> (octal
    code 011). If you do want to distinguish, make one binding for this
    ASCII character, and another for the "function key" `tab'.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
       [not found] ` <80aa389mvi.fsf@fencepost.gnu.org>
@ 2012-03-23 22:31   ` Bastien Guerry
  2012-03-23 23:28     ` Lennart Borgman
       [not found]     ` <CANbX3664-BAqs7KK39__UM_Y8k_U0P-4TXfypoFLhow3evg9OA@mail.gmail.com>
       [not found]   ` <87pqc3x83n.fsf__44728.201654698$1332541889$gmane$org@altern.org>
  1 sibling, 2 replies; 5+ messages in thread
From: Bastien Guerry @ 2012-03-23 22:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 9809, Eric Hanchrow

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

> Eric Hanchrow wrote:
>
>> I started emacs with "emacs -Q".  Then I typed
>>
>>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>>
>> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
>> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
>> command flyspell-auto-correct-word".
>>
>> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
>> flyspell-auto-correct-word.
>
> This occurs because org.el for some reason tries to define the M-TAB key
> 3 different ways:
>
> (org-defkey org-mode-map [(meta tab)] 'pcomplete)
> (org-defkey org-mode-map "\M-\t" 'pcomplete)
> (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
>
> Removing all but the second definition would fix this.
>
> Ref "Named ASCII Control Characters" in the lispref.
>
>     If you do not want to distinguish between (for example) <TAB> and
>     `C-i', make just one binding, for the ASCII character <TAB> (octal
>     code 011). If you do want to distinguish, make one binding for this
>     ASCII character, and another for the "function key" `tab'.

Thanks.  This is now fixing in Org repo, I'll close the bug when
this goes into Emacs.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
  2012-03-23 22:31   ` Bastien Guerry
@ 2012-03-23 23:28     ` Lennart Borgman
       [not found]     ` <CANbX3664-BAqs7KK39__UM_Y8k_U0P-4TXfypoFLhow3evg9OA@mail.gmail.com>
  1 sibling, 0 replies; 5+ messages in thread
From: Lennart Borgman @ 2012-03-23 23:28 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: Glenn Morris, 9809, Eric Hanchrow

On Fri, Mar 23, 2012 at 23:31, Bastien Guerry <bzg@altern.org> wrote:
>
> Hi Glenn,
>
> Glenn Morris <rgm@gnu.org> writes:
>
> > Eric Hanchrow wrote:
> >
> >> I started emacs with "emacs -Q".  Then I typed
> >>
> >>     M-x o r g - m o d e <return> M-x f l y s p e l l -
> >>     m o d e <return> C-h c <M-tab> C-h c M-TAB
> >>
> >> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
> >> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
> >> command flyspell-auto-correct-word".
> >>
> >> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
> >> flyspell-auto-correct-word.
> >
> > This occurs because org.el for some reason tries to define the M-TAB key
> > 3 different ways:
> >
> > (org-defkey org-mode-map [(meta tab)] 'pcomplete)
> > (org-defkey org-mode-map "\M-\t" 'pcomplete)
> > (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
> >
> > Removing all but the second definition would fix this.
> >
> > Ref "Named ASCII Control Characters" in the lispref.
> >
> >     If you do not want to distinguish between (for example) <TAB> and
> >     `C-i', make just one binding, for the ASCII character <TAB> (octal
> >     code 011). If you do want to distinguish, make one binding for this
> >     ASCII character, and another for the "function key" `tab'.
>
> Thanks.  This is now fixing in Org repo, I'll close the bug when
> this goes into Emacs.

Isn't there an underlying bug in Emacs here? Should not the flyspell
binding have overrided the org-mode-map binding from the beginning
(since org-mode-map is a major mode map)?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
       [not found]     ` <CANbX3664-BAqs7KK39__UM_Y8k_U0P-4TXfypoFLhow3evg9OA@mail.gmail.com>
@ 2012-03-24  2:00       ` Stefan Monnier
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2012-03-24  2:00 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: Bastien Guerry, 9809, Eric Hanchrow

> Isn't there an underlying bug in Emacs here?

Whether it's a bug or not depends on point of view.  flyspell takes the
position that it binds M-TAB, so if you want to bind M-tab to something
else you can (and you still get flyspell's command on C-M-i and on ESC
TAB).


        Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
       [not found]   ` <87pqc3x83n.fsf__44728.201654698$1332541889$gmane$org@altern.org>
@ 2012-04-01 10:00     ` Bastien
  0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2012-04-01 10:00 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 9809-done, Eric Hanchrow

Bastien Guerry <bzg@altern.org> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Eric Hanchrow wrote:
>>
>>> I started emacs with "emacs -Q".  Then I typed
>>>
>>>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>>>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>>>
>>> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
>>> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
>>> command flyspell-auto-correct-word".
>>>
>>> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
>>> flyspell-auto-correct-word.
>>
>> This occurs because org.el for some reason tries to define the M-TAB key
>> 3 different ways:
>>
>> (org-defkey org-mode-map [(meta tab)] 'pcomplete)
>> (org-defkey org-mode-map "\M-\t" 'pcomplete)
>> (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
>>
>> Removing all but the second definition would fix this.
>>
>> Ref "Named ASCII Control Characters" in the lispref.
>>
>>     If you do not want to distinguish between (for example) <TAB> and
>>     `C-i', make just one binding, for the ASCII character <TAB> (octal
>>     code 011). If you do want to distinguish, make one binding for this
>>     ASCII character, and another for the "function key" `tab'.
>
> Thanks.  This is now fixing in Org repo, I'll close the bug when
> this goes into Emacs.

Fixed in Emacs trunk.  Closing this bug.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-04-01 19:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAHZoxq8t3b7XUwt3zrh+iPYxCp9sQ-yAOrj1H2Y8UoEuB5sgVQ@mail.gmail.com>
2012-03-23  0:33 ` bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode Glenn Morris
     [not found] ` <80aa389mvi.fsf@fencepost.gnu.org>
2012-03-23 22:31   ` Bastien Guerry
2012-03-23 23:28     ` Lennart Borgman
     [not found]     ` <CANbX3664-BAqs7KK39__UM_Y8k_U0P-4TXfypoFLhow3evg9OA@mail.gmail.com>
2012-03-24  2:00       ` Stefan Monnier
     [not found]   ` <87pqc3x83n.fsf__44728.201654698$1332541889$gmane$org@altern.org>
2012-04-01 10:00     ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).