From: Allen Li <darkfeline@felesatra.moe>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-set-tags-command deletes inherited tags [9.3.7 (9.3.7-18-g093b47-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20200810/)]
Date: Fri, 21 Aug 2020 01:39:01 -0700 [thread overview]
Message-ID: <805z9cxuje.fsf@felesatra.moe> (raw)
In-Reply-To: <87o8n7w8i7.fsf@kyleam.com> (Kyle Meyer's message of "Wed, 19 Aug 2020 00:43:28 -0400")
Kyle Meyer <kyle@kyleam.com> writes:
> That looks good as far as fixing the misbehavior you report. I wonder
> though whether there's a deeper org-get-tags issue here worth
> considering. Its documentation says
>
> ... the returned list of tags contains tags in this order: file
> tags, tags inherited from parent headlines, local tags.
>
> But it's not specified what happens when a tag is both local and
> inherited. The current implementation drops the local tag variant
> through its delete-dups call:
>
> (delete-dups
> (append (org-remove-uninherited-tags itags) ltags))
>
> I would have expected the local tag to get priority here. If that were
> the case (e.g., something like below), that would also solve the issue
> you describe.
>
> Thoughts?
That sounds reasonable, let me prepare a new patch.
>
> -- >8 --
> diff --git a/lisp/org.el b/lisp/org.el
> index fb95590fc..3dac42b7b 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12310,8 +12310,10 @@ (defun org-get-tags (&optional pos local)
> (org--get-local-tags))
> itags)))
> (setq itags (append org-file-tags itags))
> - (delete-dups
> - (append (org-remove-uninherited-tags itags) ltags))))))))
> + (nreverse
> + (delete-dups
> + (nreverse (nconc (org-remove-uninherited-tags itags)
> + ltags))))))))))
>
> (defun org-get-buffer-tags ()
> "Get a table of all tags used in the buffer, for completion."
next prev parent reply other threads:[~2020-08-21 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 22:42 Bug: org-set-tags-command deletes inherited tags [9.3.7 (9.3.7-18-g093b47-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20200810/)] Allen Li
2020-08-19 4:43 ` Kyle Meyer
2020-08-21 8:39 ` Allen Li [this message]
2020-08-22 9:03 ` Allen Li
2020-08-24 2:43 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805z9cxuje.fsf@felesatra.moe \
--to=darkfeline@felesatra.moe \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).