From: chgreg692000@yahoo.com
To: Carsten Dominik <dominik@science.uva.nl>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-mode + xemacs + patch
Date: Thu, 11 May 2006 11:18:37 +0300 [thread overview]
Message-ID: <7upsilvusi.fsf@horizonsemi.com> (raw)
In-Reply-To: <3e5c1fd8f70c4ab0a1c887201cd1666f@science.uva.nl> (Carsten Dominik's message of "Thu, 11 May 2006 05:58:19 +0200")
On Thu, 11 May 2006, dominik@science.uva.nl wrote:
> Hi Greg, I have looked at you patch and taken most of it. However,
> I have a few questions:
>
>> \\{org-mode-map}"
>> +
>> + ;; Get rid of Outline menus, they are not needed
>> + ;; Need to do this here because define-derived-mode sets up
>> + ;; the keymap so late.
>> + (if (featurep 'xemacs)
>> + (progn
>> + (if org-noutline-p
>> + (progn
>> + (easy-menu-remove outline-mode-menu-heading)
>> + (easy-menu-remove outline-mode-menu-show)
>> + (easy-menu-remove outline-mode-menu-hide))
>
> This assumes that the future port of noutline will use easy-menu for
> its stuff. OK if you get your version into XEmacs, problematic
> otherwise. I have taken it anyway, because right now it does not
> break anything.
>
>> (get-char-property (1- (point)) 'invisible))
>> (beginning-of-line 2)) (setq eol (point)))
>> (outline-end-of-heading) (setq eoh (point))
>> - (org-end-of-subtree t) (setq eos (point))
>> + ;;(org-end-of-subtree t) (setq eos (point))
>> + (outline-end-of-subtree) (setq eos (point))
>> (outline-next-heading))
>
> Why is the above change necessary?
Without this change 'org-cycle' gives error when
'org-cycle-include-plain-lists' is t.
>
>> (if (equal x "") (setq x "0"))
>> - (setq form (replace-match (concat "(" x ")") t t form)))
>> + ;;(setq form (replace-match (concat "(" x ")") t t form)))
>> + (setq form (replace-match x t t form)))
>
> I guess you need this to get the value of variables directly into
> the list form. I need the parenthesis, because fields in tables can
> be complex expressions, and in an equation precedence rule may pull
> this expression apart, which is not wanted. We need to do this in a
> way that the parenthesis are only ignored for lisp expressions.
>
>>
I've suspected that you added these parenthesis for some reason, but
because my simple tests worked without them and because parenthesis
used only in row formulas and not used in column formulas i removed
them. I suppose it could be easy to add some if statement that will
ignore parenthesis for elisp only.
>> +(when (featurep 'xemacs)
>> + (define-key org-mode-map 'button3 'popup-mode-menu))
>> +
>> (defsubst org-table-p () (org-at-table-p))
>
>
> Any other XEmacs users who object to this change?
>
>> @@ -13772,7 +13790,8 @@
>> Only visible heading lines are considered, unless INVISIBLE-OK is
>> non-nil."
>> (if org-noutline-p
>> (outline-back-to-heading invisible-ok)
>> - (if (and (memq (char-before) '(?\n ?\r))
>> + (if (and (or (memq (char-before) '(?\n ?\r))
>> + (point-min))
>> (looking-at outline-regexp))
>> t
>
> This one I don't understand. Maybe you mean
>
> (if (and (or (bobp) (memq (char-before) '(?\n ?\r)))
>
> ???? Point-min is never nil, it is always just a number.
>
This is a bug. It should be (bobp). Have no idea why it's worked with
(point-min).
>
>
> Thanks.
>
> - Carsten
Regards,
Greg
next prev parent reply other threads:[~2006-05-11 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 14:23 org-mode + xemacs + patch chgreg692000
2006-05-09 14:58 ` Carsten Dominik
2006-05-10 7:40 ` chgreg692000
2006-05-11 9:44 ` Carsten Dominik
2006-05-10 10:49 ` Carsten Dominik
[not found] ` <7u3bfit8ov.fsf@horizonsemi.com>
2006-05-10 11:50 ` Carsten Dominik
2006-05-11 3:58 ` Carsten Dominik
2006-05-11 8:18 ` chgreg692000 [this message]
2006-05-11 9:01 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7upsilvusi.fsf@horizonsemi.com \
--to=chgreg692000@yahoo.com \
--cc=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).