From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id mCDsCmr2QWaf2QAAe85BDQ:P1 (envelope-from ) for ; Mon, 13 May 2024 13:15:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id mCDsCmr2QWaf2QAAe85BDQ (envelope-from ) for ; Mon, 13 May 2024 13:15:54 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=jUPThBia; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715598954; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+R9oBPShZwp66jQpsEPxdjis/AYzTBtkOcJujNUGjN8=; b=XOodtxflSj2xZaNyNmkNH1gGxGxDB0mngiz26oY9kmpmBS0+aIuj4bsNw/CsjVDV/NsYSB BN06P2vBV4gC8Ed6CXVbjNGmfsefdKX2/9tcH/QVM4vyzKevS3yJdpydQlCSFCEurAkxrt zLRPayBaJcooHHCD4vCA92CR7qWA2d1zcOIvX3iON2H1WT46Z0zUA4l08KLtCsJ8KeTDhE s4nUbCoE1l3G8ggBB4lY/GJ0T7cGEHg5vnS6bPebGT2YK5DU4HALxGEuafpJzsJu7blTgK JsYIPE6qngjZK4y23SRZAKVPJI5FgVjRZlstS3FFJZDxI6T1ejUvRMOGAp4rIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=jUPThBia; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715598954; a=rsa-sha256; cv=none; b=G/wNmnPQ8+dTdzrGNOd+oLlB4TmHmNk87Pk+KCmlIOBwKNValjHH4c+fFjUNyVRxTFEAK8 JEBjUqXLZLuQt5wcxADykwmhfL557YmcQcPKoWV1YA8yq5z6lNRjDpAS1sAe6dBpfzkP03 yKk44WFqBWlhO9CDZ3G9dYYmM7QvAgLgLXw2d2LacHzCNvHdC3uCzQXq5yCPJ/Vn93ITgu Jnv8gdYubScm7g0QkMMm/wfqR6J/ijTcr7UHzBeEDbat4cTK+ZIVy5XmzEq2TjnD8eixVb noDDe1jstj8uPznuQJDfGSKeLKN6MQNx0EzalZ6sMHBlAlJcTpUNq9ZshOocGg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F331414B14 for ; Mon, 13 May 2024 13:15:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6Tdt-0007vV-Fm; Mon, 13 May 2024 07:14:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Tdr-0007ul-DE for emacs-orgmode@gnu.org; Mon, 13 May 2024 07:14:51 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6Tdp-0004It-Fz for emacs-orgmode@gnu.org; Mon, 13 May 2024 07:14:51 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2e3b1b6e9d1so51629881fa.2 for ; Mon, 13 May 2024 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715598887; x=1716203687; darn=gnu.org; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=+R9oBPShZwp66jQpsEPxdjis/AYzTBtkOcJujNUGjN8=; b=jUPThBiayvB5MH2ljk6CThCLZ8wnnvGAkH/hZDuQfh0B7EN91548qm9NvkW6Rg0cke hjp2PKtWXhUTnACUjAgTSdFEawgMgfE8B+peOFoycjxwJiXuS2SMVz9gVBoCBA7yI/DE mZCLBOzA2RbD7JsXQlA6D1vUieETmTC/TcnKL42ZVz65rSI6koY5SLWbz3NFQ6AUGGJ0 wtbAFTUEsiQvJAufOsCf8ABLptBwVJkqYDgxPkdnYAzqgJYJ24ENvm/ghUWGs4js0wzD JB2ayhGX37NPlUrxD11hFQhrHnNLlIkHVTp2XX9mFxxmPjX7EpJetCdqurYY4i+Dh2h/ FTMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715598887; x=1716203687; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+R9oBPShZwp66jQpsEPxdjis/AYzTBtkOcJujNUGjN8=; b=lr2SfLr4sCeUOG3r2R12+8bhFqLew+/kbb/GPLEN1NGxQNc95W263fHvcpvm6QIobn YcyFSmq34es24XzdgfM+zIO+W+cY+oeOKGRFocs2uAqHK/irLCnZFRPBB1I9XqO2TdUg ONpOK6HVZtQhreCJVP6tk7Wv1s42l5Nj19pnNImE04vQL7e7kybcwY8jZmnm4t6G+xhR 0SMMREz8v8HgGIiFD0Kt4sJ8FjjGJMfAFV2mzBhyiOxlQIN+m2r/YUXLcPOBP+mG0Fdz OZvA/fdF+cBNxgX2cOoQk3/ZyhcQ+mkOsIB6COQudvsC90Mt/E8wZzpm+8lj0JDMgMZc NqMg== X-Forwarded-Encrypted: i=1; AJvYcCVeZvrqi/Q5clBuL0xrRnmseP3li9Tg2j3rULrAD0eCTz3gVDvq0x4EQue+x6FzgJy3qRL//I26V6cdYs8y0l/SOqL6XRM= X-Gm-Message-State: AOJu0YwgmpVQnqHgbE7jO4S7J8+K77pEfTuedoTwcLawdQ+eCezx2LcO lUyZLKWaBAQkD4BAi78zRNG3c7R418J+TD3uqquHihG9RrcsYeJrxl5qiQ== X-Google-Smtp-Source: AGHT+IHdFMAOJMJaakqQYn0QdG45aIqeX9Tnz4T7Boe91jE6qgbT2Sh8GmswpVHKbfRuZ8gF2og2Lg== X-Received: by 2002:a2e:80c3:0:b0:2df:c2b:8c84 with SMTP id 38308e7fff4ca-2e51fd4adb7mr58670001fa.1.1715598886984; Mon, 13 May 2024 04:14:46 -0700 (PDT) Received: from [192.168.0.102] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id 38308e7fff4ca-2e4d0ce3488sm13868521fa.52.2024.05.13.04.14.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 04:14:46 -0700 (PDT) Message-ID: <7ef51938-600d-40cf-bf93-d32b86d77f9d@gmail.com> Date: Mon, 13 May 2024 18:14:45 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add support for shortdoc link type To: Bruno Cardoso , emacs-orgmode@gnu.org References: <87zftatdkr.fsf@gmail.com> <87v83xer0d.fsf@localhost> <87wmodtqxt.fsf@gmail.com> <875xvxs9hi.fsf@localhost> <87ttjhtjx1.fsf@gmail.com> <4b69d3b8-cfe7-4ba2-b9b5-872bcaeb6fe6@gmail.com> <87v83uefpd.fsf@gmail.com> <87h6fdeb3i.fsf@gmail.com> <9f6bbe0f-7cc2-4d55-a77d-331c8f71bb2c@gmail.com> <87y18ondrt.fsf@gmail.com> <938098de-6933-4668-85b0-fbfbc02dd949@gmail.com> <87v83pnm56.fsf@gmail.com> <87seysnggb.fsf@gmail.com> <87ttj4i8u6.fsf@gmail.com> Content-Language: en-US, ru-RU From: Max Nikulin Mail-Followup-To: Bruno Cardoso , emacs-orgmode@gnu.org In-Reply-To: <87ttj4i8u6.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=manikulin@gmail.com; helo=mail-lj1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.64 X-Spam-Score: 2.64 X-Migadu-Queue-Id: F331414B14 X-Migadu-Scanner: mx13.migadu.com X-TUID: 4TbCV37QhM56 On 11/05/2024 23:58, Bruno Cardoso wrote: > On 2024-05-10, 18:09 +0700, Max Nikulin wrote: >> > > I haven't yet. Will be glad to. I hope, next patch revision will be the final one, so it can be notification that the procedure is completed. (Rebase to main HEAD might be necessary.) > The attached patch is now in this format. > +++ b/lisp/ol.el > @@ -1582,7 +1582,47 @@ PATH is a symbol name, as a string." > :follow #'org-link--open-help > :store #'org-link--store-help) > Sorry, but did you manually edit the patch? git apply /tmp/org/0001-ol-support-for-shortdoc-link-type.patch error: patch failed: lisp/ol.el:1582 error: lisp/ol.el: patch does not apply and I see only 6 context lines, not 7. > + (condition-case nil > + (progn > + (shortdoc-display-group group fn) > + (and str (not fn) (search-forward str nil t))) > + (error (message "Unknown shortdoc group or malformed link: `%s'" > + path))))) If you wish to use `user-error' as in earlier revisions then you may use (error (user-error "Unknown shortdoc group or malformed link: `%s'" path))))) An alternative might be something like (feel free to ignore) (condition-case err ;; ... (error (signal 'user-error (cdr err)))) ; more ) to preserve message generated by `shortdoc-display-group'.