From: Max Nikulin <manikulin@gmail.com>
To: Bruno Cardoso <cardoso.bc@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add support for shortdoc link type
Date: Mon, 13 May 2024 18:14:45 +0700 [thread overview]
Message-ID: <7ef51938-600d-40cf-bf93-d32b86d77f9d@gmail.com> (raw)
In-Reply-To: <87ttj4i8u6.fsf@gmail.com>
On 11/05/2024 23:58, Bruno Cardoso wrote:
> On 2024-05-10, 18:09 +0700, Max Nikulin wrote:
>> <https://orgmode.org/worg/org-contribute.html#copyright>
>
> I haven't yet. Will be glad to.
I hope, next patch revision will be the final one, so it can be
notification that the procedure is completed. (Rebase to main HEAD might
be necessary.)
> The attached patch is now in this format.
> +++ b/lisp/ol.el
> @@ -1582,7 +1582,47 @@ PATH is a symbol name, as a string."
> :follow #'org-link--open-help
> :store #'org-link--store-help)
>
Sorry, but did you manually edit the patch?
git apply /tmp/org/0001-ol-support-for-shortdoc-link-type.patch
error: patch failed: lisp/ol.el:1582
error: lisp/ol.el: patch does not apply
and I see only 6 context lines, not 7.
> + (condition-case nil
> + (progn
> + (shortdoc-display-group group fn)
> + (and str (not fn) (search-forward str nil t)))
> + (error (message "Unknown shortdoc group or malformed link: `%s'"
> + path)))))
If you wish to use `user-error' as in earlier revisions then you may use
(error (user-error "Unknown shortdoc group or malformed link: `%s'"
path)))))
An alternative might be something like (feel free to ignore)
(condition-case err
;; ...
(error (signal 'user-error (cdr err)))) ; more )
to preserve message generated by `shortdoc-display-group'.
next prev parent reply other threads:[~2024-05-13 11:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 3:29 [PATCH] Add support for shortdoc link type Bruno Cardoso
2024-05-01 11:00 ` Ihor Radchenko
2024-05-01 16:52 ` Bruno Cardoso
2024-05-01 17:55 ` Ihor Radchenko
2024-05-01 19:24 ` Bruno Cardoso
2024-05-02 10:41 ` Max Nikulin
2024-05-03 21:41 ` Bruno Cardoso
2024-05-04 7:38 ` Max Nikulin
2024-05-04 17:33 ` Bruno Cardoso
2024-05-05 11:01 ` Max Nikulin
2024-05-05 21:35 ` Bruno Cardoso
2024-05-06 10:55 ` Max Nikulin
2024-05-08 1:11 ` Bruno Cardoso
2024-05-08 11:20 ` Max Nikulin
2024-05-08 21:26 ` Bruno Cardoso
2024-05-10 11:09 ` Max Nikulin
2024-05-11 16:58 ` Bruno Cardoso
2024-05-13 11:14 ` Max Nikulin [this message]
2024-05-13 13:04 ` Bruno Cardoso
2024-05-16 10:58 ` Max Nikulin
2024-05-17 14:55 ` Bruno Cardoso
2024-06-04 23:59 ` Bruno Cardoso
2024-06-05 15:14 ` Ihor Radchenko
2024-06-05 21:15 ` Bastien Guerry
2024-06-05 15:37 ` Max Nikulin
2024-06-05 22:21 ` Bruno Cardoso
2024-06-06 11:53 ` Ihor Radchenko
2024-06-06 23:11 ` Bruno Cardoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef51938-600d-40cf-bf93-d32b86d77f9d@gmail.com \
--to=manikulin@gmail.com \
--cc=cardoso.bc@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).