From: stardiviner <numbchild@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] add :session support for ob-js.el
Date: Mon, 26 Mar 2018 09:40:59 +0800 [thread overview]
Message-ID: <7b4490aa-ec98-366f-f89b-07118deab4f8@gmail.com> (raw)
In-Reply-To: <87y3if9817.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]
Thanks for your refactoring. I must be recklessof this. I will be
careful next time.
On 03/26/2018 05:09 AM, Nicolas Goaziou wrote:
> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I attached my new generated patches.
>>
>>
>> On 03/17/2018 07:14 PM, Nicolas Goaziou wrote:
>>> Some comments follow.
>>>> + (result (if (not (string= (cdr (assq :session params)) "none"))
>>> You can integrate the test above in the `cond':
>>>
>>> (cond
>>> ((string= "none" (cdr (assq :session params))) nil)
>>> ((string= "*JS REPL*" session) ...)
>>> ...)
>> This is modified in new patch.
>>>> + (sit-for .5) (goto-char (point-max))
>>> (sit-for .5)
>>> (goto-char (point-max))
>> This is in original code, might because ob-js initialize REPL backend
>> need some time so original author added `site-for`. After test, this
>> seems does not matter. So remote the sit-for now.
>>>> + (mapc (lambda (var)
>>>> + (insert var) (comint-send-input nil t)
>>>> + (org-babel-comint-wait-for-output session)
>>>> + (sit-for .1) (goto-char (point-max))) var-lines)))
>>>> session))
>>> (dolist (var ...)
>>> ...)
>> modified in new patch.
>>
>> I don't know how to apply master branch new update on my local
>> `ob-js-session` branch so to get ob-js related commits on top to
>> generate new patches. (Do you have any idea on this?) The new patches
>> are behind latest `master` branch. But should be compatible still. If
>> generating patches based on latest `master` branch commit is must,
>> I can do that.
> I applied you patch. However, I rewrote your commit messages: they need
> to refer to modified variables and functions. I also fixed dangling
> parenthesis, and fixed a typo in a move from `mapc' + `lambda' to
> `dolist'.
>
> Thank you.
>
> Regards,
>
[-- Attachment #2: Type: text/html, Size: 3042 bytes --]
prev parent reply other threads:[~2018-03-26 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:02 [PATCH] add :session support for ob-js.el stardiviner
2018-03-13 8:43 ` Nicolas Goaziou
2018-03-13 11:51 ` stardiviner
2018-03-17 11:14 ` Nicolas Goaziou
2018-03-17 17:51 ` About the assignment of FSF papers stardiviner
2018-03-18 16:15 ` Nicolas Goaziou
2018-03-22 18:47 ` stardiviner
2018-03-24 19:02 ` Nicolas Goaziou
2018-03-25 3:31 ` [PATCH] add :session support for ob-js.el stardiviner
2018-03-25 21:09 ` Nicolas Goaziou
2018-03-26 1:40 ` stardiviner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b4490aa-ec98-366f-f89b-07118deab4f8@gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).