From: tumashu <tumashu@163.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-capture: Add a custom to control save target file or not.
Date: Fri, 13 Apr 2018 10:10:26 +0800 (CST) [thread overview]
Message-ID: <77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com> (raw)
In-Reply-To: <87po34y2ya.fsf@nicolasgoaziou.fr>
At 2018-04-12 21:22:21, "Nicolas Goaziou" <mail@nicolasgoaziou.fr> wrote:
>Hello,
>
>tumashu <tumashu@163.com> writes:
>
>> I use org-capture to capture text to a file of my mobile phone
>> with the help of tramp and termux's sshd, the save buffer is very
>> slow, so I want to org-capture-finalize just update buffer, and
>> I save buffer manually when need.
>
>Thank you. Comments follow.
>
>> By the way, can we contribute org-mode with the help of PR feature in
>> code.orgmode.org?
>
>AFAIC, I'd rather deal with email than with a web interface. However,
>Bastien accepted PR from code.orgmode.org in the past.
>
>The problem with PR in code.orgmode.org is that the discussion around
>the patch happens somewhere else than on the ML.
>
>> +(defcustom org-capture-finalize-save-buffer t
>> + "When nil, org-capture-finalize will not save target file's buffer."
>> + :group 'org-capture
>> + :version "24.1"
>> + :type 'boolean)
>
>The :version value is incorrect. Also, it is missing ":safe #'booleanp".
>
:version 26.1 ? or 27.0 ?
>> (defcustom org-capture-bookmark t
>> "When non-nil, add a bookmark pointing at the last stored
>> position when capturing."
>> @@ -791,7 +797,10 @@ captured item after finalizing."
>> (org-encrypt-entry)))
>>
>> ;; Kill the indirect buffer
>> - (save-buffer)
>> + (if org-capture-finalize-save-buffer
>> + (save-buffer)
>> + (message "The capture target file is not auto saved, please save it manually."))
>
>Would it make sense to simply not call `save-buffer' in all cases?
>Saving buffer after a capture is rather opinionated.
I do not know why must save-buffer, may be for information safe :-)
>
>
>Regards,
>
>--
>Nicolas Goaziou
next prev parent reply other threads:[~2018-04-13 2:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 1:20 [PATCH] org-capture: Add a custom to control save target file or not tumashu
2018-04-12 13:22 ` Nicolas Goaziou
2018-04-13 2:10 ` tumashu [this message]
2018-04-14 7:44 ` Nicolas Goaziou
2018-04-14 9:42 ` tumashu
2018-04-16 1:06 ` tumashu
2018-04-16 10:11 ` Nicolas Goaziou
2018-09-26 17:11 ` Kaushal Modi
2018-09-26 17:29 ` Kaushal Modi
2018-09-26 18:11 ` Kaushal Modi
2018-09-27 5:47 ` Eric S Fraga
2018-09-27 13:33 ` Kaushal Modi
2018-09-28 12:28 ` Kaushal Modi
2018-09-28 20:50 ` Nicolas Goaziou
2018-09-28 21:17 ` Kaushal Modi
2018-09-29 6:31 ` Nicolas Goaziou
2018-09-29 10:27 ` Eric S Fraga
2018-09-29 10:35 ` Van L
2018-12-13 15:08 ` Kaushal Modi
2018-12-13 15:24 ` Kaushal Modi
2018-12-13 15:33 ` Kaushal Modi
2018-12-13 16:25 ` Nicolas Goaziou
2018-12-13 19:12 ` Kaushal Modi
2018-04-26 23:34 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com \
--to=tumashu@163.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).