emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Sebastian Rose <sebastian_rose@gmx.de>
Cc: Tassilo Horn <tassilo@member.fsf.org>, emacs-orgmode@gnu.org
Subject: Re: org-protocol://remember:// question
Date: Fri, 3 Apr 2009 18:58:31 +0200	[thread overview]
Message-ID: <77EE9336-35EE-41D9-A27F-4BCBF5E0D9D9@gmail.com> (raw)
In-Reply-To: <87y6uhyj25.fsf@kassiopeya.MSHEIMNETZ>

Applied, thanks.

Would you mind turning on indent-tabs-mode in these files?
I am having trouble wit the patches because of this.

Thanks.

- Carsten

On Apr 3, 2009, at 2:34 PM, Sebastian Rose wrote:

>
>
> I encountered another problem:
>
>  Using `C-c C-k' in the remember buffer is OK.
>
>  But if the user interupts `org-remember' by `C-g' (e.g. when reading
>  some text interactively), emacsclient will be waiting for ever.
>
>
> Unfortunately, there seems no easy way to fix this in a way, that we
> could mix org-protocol arguments and filenames for emacsclient.
>
> A solution for this problem is, to introduce a new property:
>
>
> (defconst org-protocol-protocol-alist-default
>  '(("org-remember"    :protocol "remember"    :function org-protocol- 
> remember :kill-client t)
> ...
>
> and unconditionally kill the client, once a sub-protocol with a non- 
> nil
> `:kill-client'  property is detected.
>
>
>
> The appended patch does all the changes we need:
>
>    - call org-remember the right way
>    - kill emacsclient for org-protocol-remember and all those  
> handlers,
>      which have the `:kill-client' property set to a non-nil value.
>
>
>
> Regards,
>
>   Sebastian
>
>
> <patch-org-protocol.el>
>
>
>
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>> On Apr 2, 2009, at 8:00 PM, Sebastian Rose wrote:
>>
>>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>>> Hi Sebastian, Tassilo,
>>>>
>>>> this can be easily fixed.
>>>>
>>>> Org-protocol may add arbitrary properties to the link properties.
>>>> For example, after a call
>>>>
>>>>     (org-store-link-props :type type
>>>>                           :link url
>>>>                           :region region
>>>>                           :description title
>>>>                           :hello "Hello world")
>>>>
>>>> a template could use "%:hello" to access and insert this
>>>> string.  I have just changed org-remember so that the
>>>> property :annotation will be the default for %a.
>>>> Sebastian, could you please add
>>>>
>>>>  :annotation (concat "[[" url "][" title "]]")
>>>>
>>>> or something similar to the call to org-store-link-props?
>>>>
>>>> Also, feel free to add any other properties that might
>>>> provide useful information for a template.
>>>
>>>
>>> Doesn't that apply to certain link types only?
>>>
>>> Also, the situation seems to be different for org-protocol- 
>>> remember. I
>>> think it's the way remember is used inside that function that has  
>>> to be
>>> changed.
>>> Maybe I can figure that out.
>>
>> Sorry my mistake.  Indeed, the way you call org-remember
>> overwrites the link property list.  What you need to do is this:
>>
>>   (let (remember-annotation-functions)
>>      (org-remember nil (string-to-char template)))
>>
>> Now, another advantage of doing it like this is that you
>> do not even have to create a temporary buffer from which you
>> launch org-remember.  Right now you do this, only for
>> the effect to get the region inserted for %i.
>>
>> Much easier will not be to set the :initial property in the
>> call to org-store-link-props.
>>
>> Thus, don't even create the *org-protocol* buffer and then do this:
>>
>>      (org-store-link-props :type type
>>                            :link url
>> 			    :annotation (concat "[[" url "][" title "]]")
>> 			    :initial (or region "")
>>                            :description title)
>>      (setq org-stored-links
>>            (cons (list url title) org-stored-links))
>>      (raise-frame)
>>      (kill-new orglink)
>>      (let (remember-annotation-functions)
>> 	(org-remember nil (string-to-char template)))
>>
>> I hope that this will take care of it.
>>
>> - Carsten
>>
>
> --
> Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449  
> Hannover
> Tel.:  +49 (0)511 - 36 58 472
> Fax:   +49 (0)1805 - 233633 - 11044
> mobil: +49 (0)173 - 83 93 417
> Email: s.rose@emma-stil.de, sebastian_rose@gmx.de
> Http:  www.emma-stil.de

  reply	other threads:[~2009-04-03 16:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  6:50 Tassilo Horn
2009-04-02 11:10 ` Sebastian Rose
2009-04-02 12:28   ` Sebastian Rose
2009-04-02 16:03     ` Carsten Dominik
2009-04-02 16:03   ` Carsten Dominik
2009-04-02 18:00     ` Sebastian Rose
2009-04-03  7:47       ` Carsten Dominik
2009-04-03 12:06         ` Sebastian Rose
2009-04-03 12:34         ` Sebastian Rose
2009-04-03 16:58           ` Carsten Dominik [this message]
2009-04-03 22:59 ` Sebastian Rose
2009-04-04  9:42   ` Tassilo Horn
2009-04-04 13:39     ` Sebastian Rose
2009-04-04 17:36       ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77EE9336-35EE-41D9-A27F-4BCBF5E0D9D9@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sebastian_rose@gmx.de \
    --cc=tassilo@member.fsf.org \
    --subject='Re: org-protocol://remember:// question' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).