From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: Small fix for Gnus integration Date: Tue, 7 Jul 2009 13:27:51 +0200 Message-ID: <77D6CC42-7360-4BEB-BD8B-5D11D85A6DE3@gmail.com> References: <87zlblscr0.fsf@delenn.lan> <871votpthb.fsf@thinkpad.tsdh.de> <878wj0pys5.fsf@delenn.lan> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MO8qB-00027I-8O for emacs-orgmode@gnu.org; Tue, 07 Jul 2009 07:28:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MO8q6-00024o-QS for emacs-orgmode@gnu.org; Tue, 07 Jul 2009 07:28:02 -0400 Received: from [199.232.76.173] (port=44202 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MO8q5-00024Q-JO for emacs-orgmode@gnu.org; Tue, 07 Jul 2009 07:27:57 -0400 Received: from mail-ew0-f208.google.com ([209.85.219.208]:57307) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MO8q5-0001Dg-6B for emacs-orgmode@gnu.org; Tue, 07 Jul 2009 07:27:57 -0400 Received: by ewy4 with SMTP id 4so5549469ewy.42 for ; Tue, 07 Jul 2009 04:27:56 -0700 (PDT) In-Reply-To: <878wj0pys5.fsf@delenn.lan> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Andreas Rottmann Cc: Tassilo Horn , emacs-orgmode@gnu.org I just applied the patch in the version I got from Tassilo. Thanks! - Carsten On Jul 7, 2009, at 12:34 PM, Andreas Rottmann wrote: > Tassilo Horn writes: > >> Andreas Rottmann writes: >> >> Hi Andreas, >> >>> Without the following patch, storing links to Gnus Article buffers >>> fails on CVS Emacs, as they (at least in my setup -- IMAP) always >>> contain a "From " line, which can't be parsed as an RFC822 header. >> >> Could you elaborate a bit, i.e. provide such an example mail? >> > This is your mail as shown by Gnus after toggling the headers: > > http://rotty.yi.org/tmp/gnus-article-buffer-sample.txt > >>> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el >>> index 41b1be7..4cc5adb 100644 >>> --- a/lisp/org-gnus.el >>> +++ b/lisp/org-gnus.el >>> @@ -128,6 +128,8 @@ If `org-store-link' was called with a prefix >>> arg the meaning of >>> (header (with-current-buffer gnus-article-buffer >>> (gnus-summary-toggle-header 1) >>> (goto-char (point-min)) >>> + (when (looking-at "From ") >>> + (next-line)) >>> (mail-header-extract-no-properties))) >>> (from (mail-header 'from header)) >>> (message-id (org-remove-angle-brackets >> >> Looking at the patch, I get the impression, that it's a solution to a >> problem you created on your own. ;-) >> >> If the first line of a mail starts with "From ", I'd say it's broken. >> > "From " lines are for example used in the mbox format[0], so I wasn't > too surprised to find it in my IMAP mails as well. However, you very > well might be right that this is a bug in the MDA (which stores the > mails, including the disputed first line, in a Maildir folder, which > is > then served by via IMAP). > > [0] http://www.qmail.org/man/man5/mbox.html > >> ,----[ http://cr.yp.to/immhf/field.html ] >> | The first line of a field begins with a name and a colon. The >> name is a >> | string of one or more graphical ASCII characters other than colons, >> | i.e., bytes between 33 and 126 inclusive other than 58. >> `---- >> >> The space has the ASCII code 32, so IMO it's not allowed as header >> field >> name. >> > I'm aware of that; but I never said that the "From " line is > supposed to > be a header field -- it preceeds the email headers. > > Regards, Rotty > -- > Andreas Rottmann -- > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode