emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Andreas Rottmann <a.rottmann@gmx.at>
Cc: Tassilo Horn <tassilo@member.fsf.org>, emacs-orgmode@gnu.org
Subject: Re: Re: Small fix for Gnus integration
Date: Tue, 7 Jul 2009 13:27:51 +0200	[thread overview]
Message-ID: <77D6CC42-7360-4BEB-BD8B-5D11D85A6DE3@gmail.com> (raw)
In-Reply-To: <878wj0pys5.fsf@delenn.lan>

I just applied the patch in the version I got from Tassilo.

Thanks!

- Carsten

On Jul 7, 2009, at 12:34 PM, Andreas Rottmann wrote:

> Tassilo Horn <tassilo@member.fsf.org> writes:
>
>> Andreas Rottmann <a.rottmann@gmx.at> writes:
>>
>> Hi Andreas,
>>
>>> Without the following patch, storing links to Gnus Article buffers
>>> fails on CVS Emacs, as they (at least in my setup -- IMAP) always
>>> contain a "From " line, which can't be parsed as an RFC822 header.
>>
>> Could you elaborate a bit, i.e. provide such an example mail?
>>
> This is your mail as shown by Gnus after toggling the headers:
>
> http://rotty.yi.org/tmp/gnus-article-buffer-sample.txt
>
>>> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
>>> index 41b1be7..4cc5adb 100644
>>> --- a/lisp/org-gnus.el
>>> +++ b/lisp/org-gnus.el
>>> @@ -128,6 +128,8 @@ If `org-store-link' was called with a prefix  
>>> arg the meaning of
>>> 	   (header (with-current-buffer gnus-article-buffer
>>> 		     (gnus-summary-toggle-header 1)
>>> 		     (goto-char (point-min))
>>> +                     (when (looking-at "From ")
>>> +                       (next-line))
>>> 		     (mail-header-extract-no-properties)))
>>> 	   (from (mail-header 'from header))
>>> 	   (message-id (org-remove-angle-brackets
>>
>> Looking at the patch, I get the impression, that it's a solution to a
>> problem you created on your own. ;-)
>>
>> If the first line of a mail starts with "From ", I'd say it's broken.
>>
> "From " lines are for example used in the mbox format[0], so I wasn't
> too surprised to find it in my IMAP mails as well. However, you very
> well might be right that this is a bug in the MDA (which stores the
> mails, including the disputed first line, in a Maildir folder, which  
> is
> then served by via IMAP).
>
> [0] http://www.qmail.org/man/man5/mbox.html
>
>> ,----[ http://cr.yp.to/immhf/field.html ]
>> | The first line of a field begins with a name and a colon. The  
>> name is a
>> | string of one or more graphical ASCII characters other than colons,
>> | i.e., bytes between 33 and 126 inclusive other than 58.
>> `----
>>
>> The space has the ASCII code 32, so IMO it's not allowed as header  
>> field
>> name.
>>
> I'm aware of that; but I never said that the "From " line is  
> supposed to
> be a header field -- it preceeds the email headers.
>
> Regards, Rotty
> -- 
> Andreas Rottmann -- <http://rotty.yi.org/>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      parent reply	other threads:[~2009-07-07 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03 21:00 Small fix for Gnus integration Andreas Rottmann
2009-07-06 18:16 ` Tassilo Horn
2009-07-07 10:34   ` Andreas Rottmann
2009-07-07 10:56     ` Tassilo Horn
2009-07-07 11:35       ` Andreas Rottmann
2009-07-07 11:27     ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77D6CC42-7360-4BEB-BD8B-5D11D85A6DE3@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=a.rottmann@gmx.at \
    --cc=emacs-orgmode@gnu.org \
    --cc=tassilo@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).