emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: nicholas.dokos@hp.com
Cc: Bastien <bzg@altern.org>,
	emacs-orgmode@gnu.org,
	Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Subject: Re: partial-completion-mode error when refiling
Date: Thu, 30 Jun 2011 15:34:39 +0200	[thread overview]
Message-ID: <757B4199-1E4F-485F-975A-48E49E0330BD@gmail.com> (raw)
In-Reply-To: <11283.1309437640@alphaville.dokosmarshall.org>


On Jun 30, 2011, at 2:40 PM, Nick Dokos wrote:

> Bastien <bzg@altern.org> wrote:
> 
>> Hi Sebastian,
>> 
>> "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
>> 
>>> When I was trying to refile an extract of an email, I got this:
>>> 
>>> Getting targets...done
>>> funcall: Symbol's function definition is void: partial-completion-mode
>> 
>> thanks for reporting this -- this is indeed something wrong with the fix
>> I made to `org-without-partial-completion' (see my other message to Paul
>> Sexton).  
>> 
>> I reverted his patch so you won't see this error again.
>> 
> 
> I'm not sure that't the problem though: the org-without-partial-completion
> macro is called in a couple of places, once in org-remember.el and twice
> in org.el. I'm not sure how many people still use org-remember, but I suspect
> quite a few. The macro basically says: execute the body while mmaking sure
> that partial-completion-body is off during the execution. At least, that's
> the intent but I haven't thought through the quoting change that Paul made.
> 
> The calls:
> 
> o org-remember-apply-template: called in the g or G case to complete tags.
> o org.el: in org-icompleting-read.


> o org.el: in org-set-tags *around* org-icompleting-read.
> 
> The last one seems superfluous at first sight, but I haven't thought about
> it yet.

Yes, this one is superfluous.


> 
> In any case, these seem fairly common situations so I think it is likely
> that the macro has been called hundreds of times (over the whole org population)
> without ill effects.
> 
> OTOH, partial-completion-mode is called explicitly in org-refile-get-location,
> like this:
> 
>     (partial-completion-mode nil)

This is not a function-calling form, but this is part of a let form,
so it just sets the variable partial-completion-mode to nil.
In effect, this does indeed turn off partial-completion-mode for
the body of the form.

> 
> Could it be that it is really meant to turn *off* partial completion mode?
> In which case, it would be better to call the org-without-partion-completion
> macro here to do the work.
> 
> In any case, this explicit call seems to be more problematic than the macro.
> After all that's what Seb hit.
> 
> Nick
> 
> 

- Carsten

  reply	other threads:[~2011-06-30 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30  8:10 Sebastien Vauban
2011-06-30  9:14 ` Bastien
2011-06-30 12:40   ` Nick Dokos
2011-06-30 13:34     ` Carsten Dominik [this message]
2011-06-30 14:05       ` Nick Dokos
2011-06-30 15:07       ` Bastien
2011-06-30 13:35     ` Sebastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=757B4199-1E4F-485F-975A-48E49E0330BD@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).