Re: Suggestion with bad patch for org-remember-templates

From: Carsten Dominik <dominik@science.uva.nl>
To: James TD Smith <ahktenzero@mohorovi.cc>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>
Subject: Re: Suggestion with bad patch for org-remember-templates
Date: Sun, 4 Jan 2009 08:23:04 +0100	[thread overview]
Message-ID: <744DA4F1-2D49-41BC-B2DD-209F97812DA0@uva.nl> (raw)
In-Reply-To: <20090103184536.GA2267@yog-sothoth.mohorovi.cc>

On Jan 3, 2009, at 7:45 PM, James TD Smith wrote:

> Hi Carsten and Wes,
>
> On 2009-01-03 18:26:16(+0100), Carsten Dominik wrote:
>> Hi Wes,
>>
>> yes, a better display of the remember template options would be  
>> useful.
>> However, right now the remember interface, because I believe that
>> James is working on a rewrite of the remember integration.  Maybe he
>> wants to put this on his list?
>>
>> - Carsten
>
> The selection interface will need to be redesigned anyway to cope with
> multi-stage selection. Using the remember buffer to display the  
> available
> templates makes sense, I also like the idea of using a tabular layout.

I think it would be better not to use the remember buffer for this,
but another, dedicated, temporary buffer.

- Carsten

>
>
> I am still working on the remember rewrite. Unfortunately I haven't  
> been able to
> devote as much time to it as I had wanted, so it's still not ready  
> for wider
> testing. I think I'm about 2/3rds of the way through the refactoring  
> and adding
> plist templates.
>
> I have auto-expanding minibuffers turned on (Emacs 22.2) and haven't  
> noticed any
> problems with them, so I'd suggest Wes give them another try.
>
>> On Dec 31, 2008, at 4:39 PM, Wes Hardaker wrote:
>>
>>> My templates for remind are numerous. So much that they don't fit  
>>> in a
>>> single mini-buffer line (and I stopped using auto-expanding  
>>> minibuffers
>>> years ago when I had issues with it; I suspect it's safer now and  
>>> I just
>>> haven't tried again).
>>>
>>> But anyway, I started thinking: you know... that *Remember* buffer  
>>> is
>>> sitting there open and blank when selecting a template. Can't we  
>>> put the
>>> list of templates there? So I hacked together a quick patch to put  
>>> the
>>> contents in the *Remember* buffer and it works just fine. I'm not  
>>> an expert
>>> elisp hacker as I dabble in it only every few years, hence the  
>>> reason "bad"
>>> is in the subject line. It's also left as an exercise to the  
>>> reader to make
>>> the inserted contents prettier (like a table, rather than one item  
>>> per
>>> line).
>>>
>>> --- org-remember.el.~1~ 2008-10-25 03:57:02.000000000 -0700
>>> +++ org-remember.el     2008-12-26 06:32:51.000000000 -0800
>>> @@ -286,7 +286,23 @@
>>>                          (string-to-char org-force-remember-
>>> template-char)
>>>                        org-force-remember-template-char))
>>>                     (t
>>> -                      (message "Select template: %s"
>>> +                      (let ((currbuf (current-buffer)))
>>> +                        (switch-to-buffer remember-buffer t)
>>> +                        (erase-buffer)
>>> +                        (insert "Select template:\n"
>>> +                         (mapconcat
>>> +                          (lambda (x)
>>> +                            (cond
>>> +                             ((not (string-match "\\S-" (nth 1 x)))
>>> +                              (format "  [%c]" (car x)))
>>> +                             ((equal (downcase (car x))
>>> +                                     (downcase (aref (nth 1 x) 0)))
>>> +                              (format "  [%c]%s" (car x)
>>> +                                      (substring (nth 1 x) 1)))
>>> +                             (t (format "  [%c]%s" (car x) (nth 1
>>> x)))))
>>> +                          templates "  \n"))
>>> +                        (switch-to-buffer currbuf t))
>>> +                        (message "Select template: %s"
>>>                               (mapconcat
>>>                                (lambda (x)
>>>                                  (cond
>
> --
> |-<James TD Smith>-<email/ahktenzero@mohorovi.cc>-|
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode