From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: [bug] org-agenda-write does not handle date stamps without day of week Date: Tue, 10 Apr 2012 13:44:26 -0400 Message-ID: <7426.1334079866@alphaville> References: <2012-03-05T15-36-35@devnull.Karl-Voit.at> <2012-03-16T17-12-15@devnull.Karl-Voit.at> <5033.1331920331@alphaville> <2012-03-16T19-40-36@devnull.Karl-Voit.at> <4859.1331966740@alphaville> <30E4D375-690C-4798-B341-51268082B826@gmail.com> <8762d74hcc.fsf@gnu.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHf7L-0008EB-JH for emacs-orgmode@gnu.org; Tue, 10 Apr 2012 13:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHf7J-0002YY-M5 for emacs-orgmode@gnu.org; Tue, 10 Apr 2012 13:44:35 -0400 In-Reply-To: Message from Bastien of "Tue, 10 Apr 2012 19:38:59 +0200." <8762d74hcc.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: news1142@Karl-Voit.at, emacs-orgmode@gnu.org, Carsten Dominik Bastien wrote: > Hi Carsten and all, > > Carsten Dominik writes: > > > since we did make a change to Org a while ago to allow date stamps > > without the name of the day, I think it is only consequent to also do > > it for this case. Must have slipped our attention back then. > > The only thing we must ensure is that this regexp matches fast > > as it is used a lot. > > > > Nick's proposal works, except for the fact that is also matches when > > the time is directly attached to day name. Maybe it is cleaner to > > not match in this case. > > > > If we are going to make the day name optional, then it is better to > > include matching of the whitespace after the date into the day-name > > part of the regexp. > > Agreed. > > > I am attaching Nick's file again, with a third proposal for an > > updated regexp. > > I tested it from reproducer.org (had to add a missing parenthesis) > and it seems to work fine. > > Carsten, please feel free to apply a patch with your new org-ts-regexp0 > proposal against master HEAD. > I think he did already (but please check!): commit 7d84b300f4cba8b726662113d4ce4ff40a76c5b5 Thanks, Nick