From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bram Adams <bram.adams@polymtl.ca>
Subject: Re: Bug (with fix): org-tempo-add-block incorrectly inserts comma
 before next `#+begin_src' during expansion [9.3.2 (9.3.2-8-g47b104-elpaplus @
 ~/.emacs.d/elpa/org-plus-contrib-20200127/)]
Date: Mon, 3 Feb 2020 13:18:56 -0500
Message-ID: <7191F9F7-A62D-4859-903C-48F5AB7C3F45@polymtl.ca>
References: <93C72314-096C-4C7A-83B6-D96F581E92D5@polymtl.ca>
 <87a7608hn1.fsf@localhost> <E655F861-183D-4BF4-917D-64456D574397@polymtl.ca>
 <87wo93j2c5.fsf@gnu.org> <70260249-4E4A-49A0-B305-A6768A7CB54F@polymtl.ca>
 <87zhdzk73c.fsf@bzg.fr> <DC91A0A4-5F85-44DC-BBD6-66C88D83E8E0@polymtl.ca>
 <87ftfrd19l.fsf@bzg.fr>
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:60937)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bram.adams@polymtl.ca>) id 1iygIj-0007td-Gn
 for emacs-orgmode@gnu.org; Mon, 03 Feb 2020 13:18:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <bram.adams@polymtl.ca>) id 1iygIh-0006pJ-U9
 for emacs-orgmode@gnu.org; Mon, 03 Feb 2020 13:18:24 -0500
In-Reply-To: <87ftfrd19l.fsf@bzg.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Bastien <bzg@gnu.org>
Cc: Ihor Radchenko <yantar92@gmail.com>, emacs-orgmode@gnu.org

Hi Bastien,

> Yes, you're right, my fix was wrong - I've followed your indication
> and removed the second occurrence of '>.
> 
> What happens is this: the template expansion calls org-edit-src-code
> which gets the wrong source block boundaries, thus escaping "#+begin"
> with a comma.
> 
> Looking at the second '>, I think there is no need for it here (it
> means: "indent the line"), so we're safe removing it without touching
> `org-edit-src-code' for now.

OK, makes sense, thanks!

Kind regards,

Bram Adams



> I still think org-edit-src-code should only be called interactively,
> not through internal calls.  I'll see if this needs to be fixed too.
> 
> Best,
> 
> -- 
> Bastien
>