From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Cc: "Martin Edström" <meedstrom91@gmail.com>
Subject: Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command
Date: Sun, 25 Feb 2024 17:41:43 +0700 [thread overview]
Message-ID: <6e49c590-ad27-4fb0-b1f2-6a89c60a0b58@gmail.com> (raw)
In-Reply-To: <874jdzjqkk.fsf@localhost>
On 23/02/2024 19:46, Ihor Radchenko wrote:
> Max Nikulin <manikulin@gmail.com> writes:
>
>> On 19/02/2024 02:36, Martin Edström wrote:
>>> +Since this is a shell-command, remember to use single-quotes
>>> +around \\='%i\\=', not double-quotes! Else a math fragment such
>>> +as \"$y = 200$\" gets butchered into only \" = 200\"."
>>
>> I am afraid, the code, not the docstring must be fixed. I have not tried
>> it, but I expect an issue with
>>
>> Test \(f' = df/dx\)
>>
>> So `shell-quote-argument' is necessary and quotes around %i must be
>> stripped similar to %s in mailcap entries in `org-open-file'.
>
> That would be backwards-incompatible.
> What about introducing %e replacement that will be shell-escaped?
Ihor, it is just a bug and its manifestation depends on content of .org
files more than on user configuration. Do you really want to allow part
of equations be executed as shell commands for the sake of miracle
backward compatibility?
To minimize user annoyance my suggestion is to strip quotes in words like
- '%i'
- "%i"
- 'something%i'
- "something%i"
- something='%i'
- something="%i"
before calling `format-spec' with `shell-quote-argument' result.
Please, revert the commit that added a misleading recommendation.
By the way, single quotes have no special meaning in cmd.exe on windows.
Example of silent error resulting in incorrect equation:
(let ((org-latex-to-html-convert-command
"printf '%%s' '%i'"))
(org-format-latex-as-html "$f'' = df/dx$"))
"$f = df/dx$"
Random parts of math becomes part of shell command:
(let ((org-latex-to-html-convert-command
"printf '%%s' '%i'"))
(org-format-latex-as-html "$f' = df/dx$"))
"/bin/bash: -c: line 1: unexpected EOF while looking for matching `''
"
Something weird may be executed in the case of sufficiently complex
equations.
It should be more reliable to pass fragment to command stdin. It can be
done if %i is missed in `org-latex-to-html-convert-command'.
next prev parent reply other threads:[~2024-02-25 10:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 23:10 Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Martin Edström
2024-02-18 16:06 ` Ihor Radchenko
2024-02-18 18:56 ` Martin Edström
2024-02-18 19:36 ` Martin Edström
2024-02-19 8:30 ` Ihor Radchenko
2024-02-21 14:38 ` Max Nikulin
2024-02-21 14:57 ` Martin Edström
2024-02-21 15:04 ` Martin Edström
2024-02-21 15:08 ` Martin Edström
2024-02-23 12:46 ` Ihor Radchenko
2024-02-25 10:41 ` Max Nikulin [this message]
2024-02-26 10:48 ` Ihor Radchenko
2024-02-26 16:37 ` Max Nikulin
2024-03-08 11:16 ` Ihor Radchenko
2024-03-09 15:23 ` Max Nikulin
2024-03-10 5:02 ` [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command) Max Nikulin
2024-03-31 8:27 ` Ihor Radchenko
2024-04-01 10:39 ` Max Nikulin
2024-04-01 11:23 ` Ihor Radchenko
2024-03-12 13:03 ` Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Ihor Radchenko
2024-03-13 14:27 ` Max Nikulin
2024-03-15 13:49 ` Ihor Radchenko
2024-03-18 10:50 ` Max Nikulin
2024-03-19 14:48 ` Ihor Radchenko
2024-03-19 14:49 ` Ihor Radchenko
2024-03-19 16:22 ` Max Nikulin
2024-03-19 16:27 ` Ihor Radchenko
2024-03-19 16:45 ` fixup! and git Max Nikulin
2024-03-19 16:50 ` Ihor Radchenko
2024-03-31 8:25 ` Warn about shell-expansion in the docstring of org-latex-to-html-convert-command Ihor Radchenko
2024-04-01 10:29 ` Max Nikulin
2024-04-01 11:15 ` Ihor Radchenko
2024-03-05 12:01 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e49c590-ad27-4fb0-b1f2-6a89c60a0b58@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=meedstrom91@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).