From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Outline and org-mode don't insert text into folded sections logically Date: Sun, 30 Oct 2011 07:28:48 +0100 Message-ID: <6CBBC924-DD81-46F0-B8ED-EC92D9B6A2AE@gmail.com> References: <1315077299.1785.YahooMailClassic@web121520.mail.ne1.yahoo.com> <837h5nh1df.fsf@yahoo.it> <877h3xibb0.fsf@gnu.org> <81ehy5uy0t.fsf@gmail.com> <87wrbxdter.fsf@gnu.org> <877h3n7usn.fsf@gnu.org> <87hb2ru7qf.fsf@gnu.org> <87vcr7srij.fsf@gnu.org> <87k47ns2vx.fsf@gnu.org> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:41463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKOt5-0003qE-GX for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 02:28:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKOt4-00069g-AD for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 02:28:55 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:36334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKOt4-00069Y-0a for emacs-orgmode@gnu.org; Sun, 30 Oct 2011 02:28:54 -0400 Received: by eye4 with SMTP id 4so5075205eye.0 for ; Sat, 29 Oct 2011 23:28:52 -0700 (PDT) In-Reply-To: <87k47ns2vx.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Kelly Dean On 30.10.2011, at 02:07, Bastien wrote: > Hi Suvayu, > > suvayu ali writes: > >> Ah! Okay that seems reasonable, lets see what others think. :) > > I've now pushed this commit so that more people can test it. While I think that this is a potentially useful idea, I would like to point out a few things: - This patch covers only one of many ways to make unwanted changes in an invisible area. Others would be delete, backspace, kill-region, yank, kill-line, and an arbitrarily long list of less obvious other commands. Full protection could only be done with pre-change-hooks or so, but would then prevent also programmed changes - something that would not be useful. `org-self-insert-command' is probably only ever used in an interactive way, so the patch as you have written it may very well function correctly. - All the code in org-self-insert-command is executed for each keypress, so one needs to be careful to have this function carry as little overhead as possible. - Currently this chokes at the beginning of the buffer because the invisibility test is also run at (1- (point)). - I am not sure if I understand the positioning code: > (if (or (eq invisible-before-point 'outline) > (eq invisible-before-point 'org-hide-block)) > (goto-char (previous-overlay-change (point)))) > (org-cycle) > (if (or (eq invisible-before-point 'outline) > (eq invisible-before-point 'org-hide-block)) > (forward-char 1)) So when I happen to be somewhere in the middle of invisible text and press a character, it seems to me that the character will be inserted at the beginning of the invisible text, and not where the cursor was. Maybe a better solution would be to save point, unfold, go back to point, throw and error and not insert the pressed character. I am not sure, though. Maybe you can explain your reasoning? Regards - Carsten