From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Problem with org-mac-message.el Date: Sat, 4 Apr 2009 10:25:43 +0200 Message-ID: <67BED2B7-68AC-4AF5-B4D3-15706A4FE6D5@gmail.com> References: <4DDA3A2E-81DA-4FAE-8D96-68D5E38E6667@gmail.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lq1CL-0004b4-9w for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 04:25:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lq1CG-0004Zt-Fp for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 04:25:52 -0400 Received: from [199.232.76.173] (port=54090 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lq1CG-0004Zl-90 for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 04:25:48 -0400 Received: from mail-ew0-f160.google.com ([209.85.219.160]:40471) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lq1CF-0005lr-BK for emacs-orgmode@gnu.org; Sat, 04 Apr 2009 04:25:48 -0400 Received: by ewy4 with SMTP id 4so1398647ewy.42 for ; Sat, 04 Apr 2009 01:25:46 -0700 (PDT) In-Reply-To: <4DDA3A2E-81DA-4FAE-8D96-68D5E38E6667@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Christopher Suckling Cc: emacs-orgmode emacs-orgmode Hi Christopher, the patch and the abstraction looks good. However, I am sure that there are quite a few people who have remember templates which call %(org-mac-message-insert-link) Let's not break their setup. Could you modify your patch so that this function still works? Thanks. - Carsten On Apr 4, 2009, at 9:18 AM, Christopher Suckling wrote: > > On 3 Apr 2009, at 17:58, Carsten Dominik wrote: > >> >> On Apr 3, 2009, at 4:49 PM, Christopher Suckling wrote: >> >>> >>> On 1 Apr 2009, at 21:21, Ed Hirgelt wrote: >>> >>>> I've found that org-mac-message-get-link has a problem inserting >>>> [["]] as the first item. >>> >>> I can't replicate this. Could you provide an example? >>> >>>> The following change makes it better... >>> >>> Unfortunately, this change breaks the code for all other >>> possibilities, and, if I understand the problem correctly, simply >>> omits a link that begins [[" >>> >>> My beginner's elisp is rather clumsy; I'm going to attempt to tidy >>> up the code anyway, so I'll be on the lookout for your difficulty >>> whilst I do so. >> >> I think I already fixed it..... >> > > Thanks! I've never used mapcar before... > > I've made things more modular so that your changes are reflected in > searches for both selected and flagged mail. > > In doing so, I may have been rather naughty - I've changed the > function names so that they are consistent: > > (org-mac-message-insert-link) becomes (org-mac-message-insert- > selected) > (org-mac-create-flagged-mail) becomes (org-mac-message-insert-flagged) > > both of which call the function (org-mac-message-get-links) to do > their stuff. > > If this is not on, then I'll resubmit the patch with the original > function names. > Otherwise, new documentation is primed for pushing to Worg. > > Best, > > Christopher > > >