From: Carsten Dominik <carsten.dominik@gmail.com>
To: Christopher Suckling <suckling.list@googlemail.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Problem with org-mac-message.el
Date: Sat, 4 Apr 2009 10:25:43 +0200 [thread overview]
Message-ID: <67BED2B7-68AC-4AF5-B4D3-15706A4FE6D5@gmail.com> (raw)
In-Reply-To: <4DDA3A2E-81DA-4FAE-8D96-68D5E38E6667@gmail.com>
Hi Christopher,
the patch and the abstraction looks good. However, I am sure that
there are quite a few people who have remember templates which call
%(org-mac-message-insert-link)
Let's not break their setup. Could you modify your patch so that this
function still works?
Thanks.
- Carsten
On Apr 4, 2009, at 9:18 AM, Christopher Suckling wrote:
>
> On 3 Apr 2009, at 17:58, Carsten Dominik wrote:
>
>>
>> On Apr 3, 2009, at 4:49 PM, Christopher Suckling wrote:
>>
>>>
>>> On 1 Apr 2009, at 21:21, Ed Hirgelt wrote:
>>>
>>>> I've found that org-mac-message-get-link has a problem inserting
>>>> [["]] as the first item.
>>>
>>> I can't replicate this. Could you provide an example?
>>>
>>>> The following change makes it better...
>>>
>>> Unfortunately, this change breaks the code for all other
>>> possibilities, and, if I understand the problem correctly, simply
>>> omits a link that begins [["
>>>
>>> My beginner's elisp is rather clumsy; I'm going to attempt to tidy
>>> up the code anyway, so I'll be on the lookout for your difficulty
>>> whilst I do so.
>>
>> I think I already fixed it.....
>>
>
> Thanks! I've never used mapcar before...
>
> I've made things more modular so that your changes are reflected in
> searches for both selected and flagged mail.
>
> In doing so, I may have been rather naughty - I've changed the
> function names so that they are consistent:
>
> (org-mac-message-insert-link) becomes (org-mac-message-insert-
> selected)
> (org-mac-create-flagged-mail) becomes (org-mac-message-insert-flagged)
>
> both of which call the function (org-mac-message-get-links) to do
> their stuff.
>
> If this is not on, then I'll resubmit the patch with the original
> function names.
> Otherwise, new documentation is primed for pushing to Worg.
>
> Best,
>
> Christopher
>
>
> <org-mac-message.patch>
next prev parent reply other threads:[~2009-04-04 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 20:21 Problem with org-mac-message.el Ed Hirgelt
2009-04-03 14:49 ` Christopher Suckling
2009-04-03 16:58 ` Carsten Dominik
2009-04-04 7:18 ` Christopher Suckling
2009-04-04 8:25 ` Carsten Dominik [this message]
2009-04-04 8:52 ` Christopher Suckling
2009-04-04 10:33 ` Carsten Dominik
2009-04-05 21:43 ` Christopher Suckling
2009-04-06 4:44 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67BED2B7-68AC-4AF5-B4D3-15706A4FE6D5@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=suckling.list@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).