emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Eric S Fraga <ucecesf@ucl.ac.uk>,
	org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: full production use of org-mode: time to say thanks again!
Date: Mon, 11 Oct 2010 10:04:15 +0200	[thread overview]
Message-ID: <664F7423-EE5E-40E8-B6B3-CE2EEB4E08BC@gmail.com> (raw)
In-Reply-To: <871v7xz182.wl%n.goaziou@gmail.com>

Hi,

On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:

> Hello,
>
> Could you try the following patch and tell me if it fixes your issue?

A quick test shows that things seem to work well in inlinetasks which  
are properly ended with an END line.

There is also a dirty form of inline tasks which allows
only a planning line (SCHEDULED etc) and one or several
drawers directly after the task line, and then no
END line is necessary.  But I guess it is fair
to force the END line if you do want to have
proper indentation.

Eric Fraga, have you tested the patch yet?  Please do
so when you wake up from your two-week sleep, so that
we can check this in.

Thanks Nicolas!

I am seeing now two things that should be added:

   - M-RET after inline tasks should ignore the inline task
     and make a new entry with normal indentation
   - Maybe I should treat inline tasks with proper END
     statement as a drawer and fold it?  Comments?


>
> As a side note (to maintainers), the second patch isn't really needed,
> but I thought, while I was at it, that it would make sense
> (`org-inlinetask-min-level' doesn't need to be a boolean).

Hmmm, what happens is a user has customized this variable and it has a  
value nil.  I guess then your patch will break things?

So I think we need to keep testing the value in the code, but it is OK  
to change the customize type.

>
> Regards,
>
> -- Nicolas
>
> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002- 
> inlinetask-Make-org-inlinetask-min-level-an-integer-.patch>

- Carsten

  reply	other threads:[~2010-10-11  8:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-09 10:46 full production use of org-mode: time to say thanks again! Eric S Fraga
2010-10-09 15:26 ` Carsten Dominik
2010-10-09 17:00   ` Nicolas Goaziou
2010-10-10 18:01     ` Eric S Fraga
2010-10-11  6:34       ` Nicolas Goaziou
2010-10-11  8:04         ` Carsten Dominik [this message]
2010-10-11 11:15           ` Paul Mead
2010-10-11 15:12           ` Nicolas Goaziou
2010-10-11 15:16           ` Nicolas Goaziou
2010-10-11 15:37           ` Eric S Fraga
2010-10-14  8:32           ` Carsten Dominik
2010-10-11 15:33         ` indenting after inline task (was Re: full production use of org-mode: time to say thanks again!) Eric S Fraga
2010-10-14  8:16         ` full production use of org-mode: time to say thanks again! Carsten Dominik
2010-10-10 17:56   ` Eric S Fraga
2010-10-11  8:01     ` Carsten Dominik
2010-10-11  9:01       ` Eric S Fraga
2010-10-09 16:48 ` Christian Moe
2010-10-09 17:15   ` Nick Dokos
2010-10-09 19:03     ` Christian Moe
2010-10-11 19:33       ` Jeff Horn
2010-10-12  8:04         ` Carsten Dominik
2010-10-12  8:08         ` Eric S Fraga
2010-10-19  8:27         ` Sébastien Vauban
2010-10-20  2:45           ` Jeff Horn
2010-10-20  8:01             ` Sébastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=664F7423-EE5E-40E8-B6B3-CE2EEB4E08BC@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    --cc=ucecesf@ucl.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).