From: Carsten Dominik <carsten.dominik@gmail.com>
To: Erik Iverson <eriki@ccbr.umn.edu>
Cc: Achim Gratz <Stromeko@nexgo.de>,
emacs-orgmode@gnu.org, Antti Kaihola <akaihola@gmail.com>
Subject: Re: Re: org-indent mode not indenting free text?
Date: Fri, 3 Dec 2010 23:33:08 +0100 [thread overview]
Message-ID: <655A2791-E195-4D7D-B912-543BC281DC16@gmail.com> (raw)
In-Reply-To: <4CF95F69.3050303@ccbr.umn.edu>
Hi Erik,
thank you for your persistence, and sorry that I have
not been taking the time to explain myself clearly, in
this way I have made this thread unnecessarily long.
OK, lets look at exhibit 1:
((and org-indent-mode
(not (org-version-check "23.1.50" "Org Indent
mode" :predicate)))
(message "org-indent-mode can crash Emacs 23.1 - refusing to
turn it on!")
This test is run when someone tries to turn
on org-indent mode. If this is not Emacs 23.1.50 or later, org-indent
mode will not be turned on, and none of the remaining code in
org-indent.el will actually run, because the mode is never turned on.
Now, exhibit 2:
(if (and (not (fboundp 'with-silent-modifications))
(or (< emacs-major-version 23)
(and (= emacs-major-version 23)
(< emacs-minor-version 2))))
(defmacro with-silent-modifications (&rest body)
`(org-unmodified ,@body)))
This is code to supply a replacement macro in Emacsen where
`with-silent-modifications' was not defined. The idea was that
maybe there are a few minor versions of Emacs where this
macro is not defined, and where org-indent-mode might still
be able to work. Since I did not know
exactly when the macro was introduced, I put in some
version test which I now see is not very useful at all.
Is there anyone here who has Emacs 23.1.50 currently running?
Can you tell me if with-silent-modifications is defined in
"emacs -q" [1]? If that is the case, then we can remove the
entire top-level form.
I hope I am making a bit more sense now.
Thanks
On Dec 3, 2010, at 10:21 PM, Erik Iverson wrote:
>
>
> Carsten Dominik wrote:
>> Hi Erik,
>> On Dec 3, 2010, at 5:18 PM, Erik Iverson wrote:
>>> Just a guess here: This may be some weirdness
>>> because the check in org-indent *will* allow
>>> people using GNU Emacs 23.1.50 to turn on
>>> org-indent, as far as I can tell.
>> org-indent-mode should work in 23.1.50, this is the
>> release where the fix was made.
>>>
>>> The message "org-indent-mode can crash Emacs 23.1"
>>> does not fully explain if it can also crash 23.1.50.
>> Yes, may be this is not so clear. The current setup forbids it
>> before 23.1.50, and allows it from 23.1.50. At least that is
>> what I meant. Is there a bug?
>
> No, I did not realize that this is what was indeed meant.
> More below...
>
> <snip>
>
>>>>> Could you back out the change
>>>>> (most likely the defmacro for with-silent-modifications in org-
>>>>> macs.el,
>>>>> even though I have no clue why this would interact with org-
>>>>> indent-mode
>>>>> as it should not be defined for versions >23.1) and tell us if
>>>>> that
>>>>> solves your problem (which I can't test because org-indent-mode
>>>>> doesn't
>>>>> even start on Emacs 23.1)?
>>>> Yes it does! I commented out:
>>>> ;;(if (or (< emacs-major-version 23)
>>>> ;; (and (<= emacs-major-version 23)
>>>> ;; (< emacs-minor-version 2)))
>>>> ;; (defmacro with-silent-modifications
>>>> ;; (org-unmodified)))
>>>> and it now works correctly. Thanks a lot!
>> I have now changed the definition like this:
>> (if (and (not (fboundp 'with-silent-modifications))
>> (or (< emacs-major-version 23)
>> (and (= emacs-major-version 23)
>> (< emacs-minor-version 2))))
>> (defmacro with-silent-modifications (&rest body)
>> `(org-unmodified ,@body)))
>
> I must admit I don't understand the above macro,
> but what I was getting at before was:
>
> It only appears defined for Emacs < 23.2,
> So in particular, 23.1.50 is 'stuck' in
> between these two version checks, and maybe
> that's causing Antti's issue?
>
>> May I ask you to pull and check if this is
>> working for you out of the box?
>
> Works for me fine on Emacs 23.2, we will see
> if it does for Antti also.
>
>
next prev parent reply other threads:[~2010-12-03 22:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 16:47 org-indent mode not indenting free text? Erik Iverson
2010-11-23 18:51 ` Nicolas Goaziou
2010-11-23 20:35 ` David Maus
2010-12-02 7:57 ` Antti Kaihola
2010-12-02 20:17 ` Achim Gratz
2010-12-03 13:30 ` Antti Kaihola
2010-12-03 16:18 ` Erik Iverson
2010-12-03 19:57 ` Carsten Dominik
2010-12-03 21:16 ` Achim Gratz
2010-12-03 21:21 ` Erik Iverson
2010-12-03 22:33 ` Carsten Dominik [this message]
2010-12-04 9:12 ` Achim Gratz
2010-12-03 17:08 ` Achim Gratz
2010-12-02 18:51 ` Carsten Dominik
2010-12-02 20:29 ` Erik Iverson
2010-12-02 20:32 ` Erik Iverson
2010-12-03 13:15 ` Antti Kaihola
2010-12-02 20:42 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655A2791-E195-4D7D-B912-543BC281DC16@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=Stromeko@nexgo.de \
--cc=akaihola@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=eriki@ccbr.umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).