emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Christopher M. Miles" <numbchild@gmail.com>
To: Org mode (mailing-list) <emacs-orgmode@gnu.org>
Subject: [QUESTION] Hope to improve the `org-set-font-lock-defaults` performance by lazy and limit to current visible area
Date: Thu, 25 May 2023 12:13:18 +0800	[thread overview]
Message-ID: <646ee2c7.170a0220.bc877.0cfa@mx.google.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]


I'm the developer of Org mode package "org-link-beautify"
https://repo.or.cz/org-link-beautify.git . The package main theory
is to use org-link-parameters `:activate-func` to do link file preview
with generating thumbnail images or file content etc.

But I found it's slow one some big Org file and slow on small Org file
when previewing has a lot.

I locate and studied the source code of the `:activate-func`.

- [X] locate the core function source code
  + [X] org-link-set-parameters
    - [X] org-link-parameters
      + [X] :activate-func
  + [X] org-mode major mode definition
    + [X] org-set-font-lock-defaults - Set font lock defaults for the current buffer.
      - [X] variable: org-font-lock-extra-keywords - dynamically scoped
        + [X] org-activate-links
          - [X] org-activate-links--text-properties
            + [X] :activate-func
          - [X] org-activate-links--overlays
            + [X] :activate-func

I can see the `org-mode` invoked `org-set-font-lock-defaults` soon when
`org-mode` enabled. I hope the link `:activate-func` function can be
called only on link elements which is VISIBLE (means unfolded subtrees
or similar). So org-mode don't need to render all buffer links at
beginning soon. Instead render them as needed as unfolded. (Maybe I read
source code without fully understand the code. If so, correct me,
thanks.)

So, I hope Org mode maintainer can improve this mechanism. Thanks a lot.

Hope this can improve other Org mode extensions performance too.

-- 

[ stardiviner ]
I try to make every word tell the meaning that I want to express without misunderstanding.

Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

next             reply	other threads:[~2023-05-25  4:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  4:13 Christopher M. Miles [this message]
2023-05-25  6:40 ` [QUESTION] Hope to improve the `org-set-font-lock-defaults` performance by lazy and limit to current visible area Ihor Radchenko
2023-05-25  7:06   ` [SOLVED] " Christopher M. Miles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=646ee2c7.170a0220.bc877.0cfa@mx.google.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).