From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CKRdChAsYmRKkAAASxT56A (envelope-from ) for ; Mon, 15 May 2023 14:56:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gElaCRAsYmSbGAEAG6o9tA (envelope-from ) for ; Mon, 15 May 2023 14:56:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B37B627E65 for ; Mon, 15 May 2023 14:56:47 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyXkE-0007Ou-8n; Mon, 15 May 2023 08:56:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyXk3-0007OB-K8 for emacs-orgmode@gnu.org; Mon, 15 May 2023 08:55:55 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyXk1-0007Wm-LO for emacs-orgmode@gnu.org; Mon, 15 May 2023 08:55:55 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-643465067d1so9346094b3a.0 for ; Mon, 15 May 2023 05:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684155352; x=1686747352; h=mime-version:in-reply-to:reply-to:date:subject:cc:to:from :user-agent:references:message-id:from:to:cc:subject:date:message-id :reply-to; bh=MvAJ6XERTYZ4T1IHye0m6cp8gt1cp3zqSQqyWjEsYXQ=; b=kv+DYOGqoHyPkX1EyVScBN8BkKPDklnknNI620ZcwxE1EwAi7zRlKyPB3WJtOHhGhd xDO01p//m8jPBfigw9Md69yPMDFs/h3qJ1vKUK0PXna7N9I6jLU1LsEZWemehQiyMqwo IsiTqEOGIb/c8zmo66lv+OmUj3OWC1WsTOR7pRZ5tIJbMCdaLwhZ3CcnimSB/jYEh0Gl HKJkVXBhluovutLm7s67v3/andq0Uk1wg4htTGjE20KVf31UawN2pMQF+KzSxcfIblXB bR8E+pPl1LkRnqdAN4TBe37FJwwuiT3H39G6ol+dXvSz70QOIBvhu6ZXrM/FvGlJObgt dDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684155352; x=1686747352; h=mime-version:in-reply-to:reply-to:date:subject:cc:to:from :user-agent:references:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvAJ6XERTYZ4T1IHye0m6cp8gt1cp3zqSQqyWjEsYXQ=; b=RjHnYJxlxzXjP0PrcjQz+RX6s84owHP82FIJPV+F7P8vYqzfj4AgNBCUAOEhZ1Xa9P vGtzDCOl/5vQ2L68HbPAkBOebEbXJM9C5lNdpju3tnjmAN1J7jVUIAB3fYuj2yLpg4pJ 1iudQBNuF6HXlVfgYYfKE7GyocYnnuUWGffqiduVkBAzL8cKA8Ww1lxqaibGvBPQO/mX /uVs9eNlZAACO+ptmFGkZjrDdNQ15KLIZHfFkjpdnwGTXbUXUoAb0qAbmg+Ei4Iuno1O Y6sBpBNUgdBrZmbcAFx8+GpHcQNaKsBBToiRvzC9L6e5Yr/opV43peybGN2hfjjzgL4h sbeA== X-Gm-Message-State: AC+VfDx2EEFsYQoQnj/TAkLcRVvJM7FpWSylAdt3iidrgwvAdHFpuAgp qdWgKD4O6kTFI3/XrcXpRg== X-Google-Smtp-Source: ACHHUZ70XVS9WS6Zzno1VoNu5Alhx9zscMGMSY2o1xVWel3IP+RjrB6ia6f8Ljo8S+oALyT49YmfaQ== X-Received: by 2002:a05:6a00:2d97:b0:636:f899:4696 with SMTP id fb23-20020a056a002d9700b00636f8994696mr45637067pfb.24.1684155352072; Mon, 15 May 2023 05:55:52 -0700 (PDT) Received: from Mac-mini.local ([39.171.215.147]) by smtp.gmail.com with ESMTPSA id n3-20020aa78a43000000b005d72e54a7e1sm11697493pfa.215.2023.05.15.05.55.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 15 May 2023 05:55:51 -0700 (PDT) Message-ID: <64622bd7.a70a0220.d2249.62a1@mx.google.com> X-Google-Original-Message-ID: Received: by Mac-mini.local (Postfix, from userid 501) id F37558DAF402; Mon, 15 May 2023 20:55:26 +0800 (CST) References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> <87wn1cgjij.fsf@localhost> <64604168.170a0220.99926.5b4f@mx.google.com> <87lehrgwqn.fsf@localhost> <6460f5e3.630a0220.b9085.17d2@mx.google.com> <87ilcvdknx.fsf@localhost> <64611586.a70a0220.53db4.4151@mx.google.com> <871qjiiziz.fsf@localhost> <64612e34.170a0220.28faa.5dcb@mx.google.com> <87v8gthnc9.fsf@localhost> User-agent: mu4e 1.10.3; emacs 30.0.50 From: "Christopher M. Miles" To: Ihor Radchenko Cc: "Christopher M. Miles" , Org-mode Subject: Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` Date: Mon, 15 May 2023 20:43:55 +0800 In-reply-to: <87v8gthnc9.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=numbchild@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684155408; a=rsa-sha256; cv=none; b=P3b3S0qdkiZJL97yIAh1RxZOekAS3b4xpxCsG5FqPZeZdpi4UwcVfP6UH51JpHTPw9J/TK FXV6ILGznZHCyL53db3VkwTlb5eHCR2JrWGljReqi3DQGt5AUbxku3BNKyxFF31jKb5nLr miYZZTQB2uscWyXDuCG9OJhBUdKIR3ePVcuMk0Mo0RrbSoaC6JSIwRvZHQSRbVDp8uNJMN P/sb85hfvB2cpsCZKlJNWGgFJ00dzrbSPGwr6MCEhsIV05cFNy44xKgdBJRxAGgcQv4oz3 pxdK8ZyJaanNRCxCj95+GfaInIH7scMuIbbJAIfZLnZNVsi02178Iqnczh/WFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kv+DYOGq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684155408; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MvAJ6XERTYZ4T1IHye0m6cp8gt1cp3zqSQqyWjEsYXQ=; b=icNnJTarqz3b40ArETMK/znNOxAjE4XC4YeoN0ouF7zXtC9TVQsea8rlTQB0FFwbIEtvPl jL9FBlNmAmXzg0xnhVvJGEpSZdCeUJ2OLLahz+hF5Z7JWkJrl9HbQh24OADYqJTljDQLnK ggFhZ0qKZD6FaBCIUBeTeUEfh8TXaF0m2QgVbmwrYPnjUtok+HOemeiYNyhdq+mxF2c0+/ J1TP8R8vz2vrAnjFgBbEEPmHjkVpYVtrhyHY994L8ZMVe4Ajd6kxrO0fVj5N/onJS6xViZ zRUrNlPYzbLzLqxdl6pYysBYwBGmcojWAqWK9802gU6fgMoR25puOytQu/wmCQ== X-Migadu-Spam-Score: -6.69 X-Spam-Score: -6.69 X-Migadu-Queue-Id: B37B627E65 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kv+DYOGq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: kG7/TqDqD1on --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> You are almost there. >>> Just run your code only when (lentgh> fulltable 26). >>> >>> Of course, 26 should be a defcustom rather than a hard-coded constant. >>> And do the same for `org-fast-todo-selection'. >> >> Ok, I added defcustom option, and add cl-case condition on custom option >> `org-use-fast-tag-selection'. > > I do not think that we need to care about the value of > `org-use-fast-tag-selection'. Instead, just > > 1. If the total number of tags does not exceed > `org-fast-tag-selection-maximum-tags', display them all. > 2. If the total number of tags is larger, just display all the bound > tags + any extra tags, up to `org-fast-tag-selection-maximum-tags', > and add a note in the tag selection buffer that more tags are not > displayed. I think we should consider the option `org-use-fast-tag-selection'. Because it controls the behavior that whether auto assign short-key to tags. Make condition decision based on this option is needed. I hope you can reconsider this. =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express without mi= sunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmRiK7sACgkQG13xyVro msN0DQgAkBf53pQhKre+jC2dpUyl7QlBgCAx3iIVhZrCfw1jmFc876eyl9ELKJA0 yj0yfHd2i0LVlq6c/eQSJScHPIl/hXCyHi3PYoaTsIR1cc66ARX/OGXD1nOkYO4U n/0juLSbFttx5QnoMCvOqsgeOBtfRZM0uf3FXKpFkWSWKlR1wxkleiFhm3FiWRGL 1h52ik1MwHJ2Jp2CQSjgS1YSURkHTMPeoENTwNwv1SsoT3/fd9H/Omxc26ea5wDN VwW+OK11/R78ZJmAk2N21mnoS3VmncXYJgN46seP1FnHA+gGYelOTCg097HVf6zK x3U0BTxea6EDk+TkU1p784B9vaSW/Q== =IB3R -----END PGP SIGNATURE----- --=-=-=--