From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id HwNMOha5xWPfXgEAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 21:52:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wDmqOBa5xWP+lQAAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 21:52:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 999F837CFC for ; Mon, 16 Jan 2023 21:52:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHWSG-0002vs-9Q; Mon, 16 Jan 2023 15:51:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHWSF-0002up-2G for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 15:51:43 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHWSD-0006uD-AE for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 15:51:42 -0500 Received: by mail-pj1-x1029.google.com with SMTP id z9-20020a17090a468900b00226b6e7aeeaso32160738pjf.1 for ; Mon, 16 Jan 2023 12:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:date:subject:cc:to:from:user-agent :references:message-id:from:to:cc:subject:date:message-id:reply-to; bh=51hAG5pNhLFc8y6v0+N0fyKYjjlP4TNOWDpBPTs5tjg=; b=XyxIdPwtdMISORqLwcSh2PIy6JQws6h1g673CdkJztzZR0lol0CpMDurej0YOxwxex ma7S+0k7PIV3PQDcY7/ZrxachY3fsjG0V88z2sN+0ucUHNZ6H3xuYQuk06xW4GZHUhl2 rO9mWR8qNfj4YIeuM+2ceNpw3B/xsqSFx+l//Lz4nOu4UZpJn87Mzw4V6pdu1FEmf3kD Cx8GJiKIQM8n+0bpIfWrFYJz49/6OqQ1OtekCK5uwPbjNyB9pROECsQGFNZcHGJUbawE v7b9a3Q40r8ZAyiEkbxQu+bHqgG4IYMh/SdkjeNnqMizD13RtfLRyS3bcyP0XYHNljtv puOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:in-reply-to:date:subject:cc:to:from:user-agent :references:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=51hAG5pNhLFc8y6v0+N0fyKYjjlP4TNOWDpBPTs5tjg=; b=wJlqP27VePxwZDkToRmMB39q4qSoZK0njvMdrSKjEUtzXaThDUf1oHLhx03kcB0v6h tUdDcylPbQM5niVc7qs9ltlgEACmLn1znexszsKqVtAV90DBr4SWhcNvCrYwQVhn5FBb WlT2AruBNWhSVxo9VHef4B7OLLqLe0aZ+3yWm75hfa6kZUJXb+oa+W1KcF1W6p6PjKFW /MXtJg5N5xdIPdss4ICPPfpCx4pvAsygNiFQJrnP/MbtRAKAdiM/fObSI14HUDSToO/2 mAsorarqzcaIqM1OKy2qfP2Zagba35pme5KCxupCdq34JkhiouioyKEbmmmjfRagsGtW fhmw== X-Gm-Message-State: AFqh2kpeBK70sGl+v3tD2RyRIakDnTiAcHo8q3ODbCYywTKQ+XtsdtdK nik6JrAwoeCT8xcIFVYeqGyS45HUxNk= X-Google-Smtp-Source: AMrXdXv36digMWJxGbnrI573NcwCSuw4mOfNzbofPL659EN5Q9eqVCKe49MCJkrlVYlSaE++4N9Chg== X-Received: by 2002:a17:902:e5cd:b0:192:efc2:6578 with SMTP id u13-20020a170902e5cd00b00192efc26578mr1518469plf.41.1673902299527; Mon, 16 Jan 2023 12:51:39 -0800 (PST) Received: from dingbat (220-235-140-148.dyn.iinet.net.au. [220.235.140.148]) by smtp.gmail.com with ESMTPSA id m12-20020a170902bb8c00b00172b87d9770sm1622935pls.81.2023.01.16.12.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 12:51:39 -0800 (PST) Message-ID: <63c5b8db.170a0220.e466f.2573@mx.google.com> X-Google-Original-Message-ID: --text follows this line-- References: <874jsqbvfq.fsf@kraus.my> <87358an35i.fsf@localhost> User-agent: mu4e 1.9.14; emacs 29.0.60 From: Tim Cross To: Ihor Radchenko Cc: Daniel Kraus , emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-sql: Add support for Athena Date: Tue, 17 Jan 2023 07:50:45 +1100 In-reply-to: <87358an35i.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673902358; a=rsa-sha256; cv=none; b=k9O1MgrSX7rPVcYSz55Pd63v2zgea96RhcB8NeK1y4YWlWfsm4QeKzvi4CYPP8L+mQpqey T6CmXGUKUZx4pkCx7Riknmee1vVETCp1Al4vd93TK2nGmMcFIaF1r+VaKxsofZWx0aBTeM FjLwYanNA5ua30i+wmz37vj9SYSVq9aSiUSenG9Z0ysKoIISkT0duM4V3hwM+gQwXcgaj1 bHrMLyiTQZzDIF2v78GxlRjAaOK4l28bNxxPM/NPW/jxfLb4tutLvhqZzL7rNPenx+kfLq 922AmHp10hHTAw4zNH3c44BVup2+NO8tVtyxsO1eyKC2fLeU7xFLfmGKG7Ye1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XyxIdPwt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673902358; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=51hAG5pNhLFc8y6v0+N0fyKYjjlP4TNOWDpBPTs5tjg=; b=rPL9qfBElaf27t3SiS7qpHZA1GuJVmF4eFpIJD/fNPZrTJVsVkhcq3WK133A2Zq287hTtp yKiZGZtWx1gd8e23r/EB4989oJJRsBi0LbzjY2bTNi7ZCk3/w7srT/WEmDHCuno7LsObg5 6jr7wYGHUbrB5blYO3Siu+6JiQyGpiJ0OWC6ycja7QB68BCMHnDlgahURW+0gMXkkNRMp1 757Cgk5KR90/Ygas+TNjmSgUQTOvROxYS7YA5UXO9LT8YWcs6j7NLtFDw4gnnxrFBEO2c2 QjfXYwtwCADom3Wt2PEpqHl78KuOIBBGz+cZGYH3DvZFP9hQf2EMQi9quLy8ug== X-Migadu-Spam-Score: -4.78 X-Spam-Score: -4.78 X-Migadu-Queue-Id: 999F837CFC X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XyxIdPwt; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: TenqF1OuBKOj Ihor Radchenko writes: > Daniel Kraus writes: > >> I'm using this patch since a few month that adds support >> for AWS Athena. >> The only thing that's maybe against adding it is that >> `athenacli` (https://github.com/dbcli/athenacli) is not an >> official AWS tool but just a Python script. >> >> What's the opinion on this? > > Is this something commonly used? > > I see two main issues with the idea: > 1. I do not like the idea of adding all the possible CLI tools over > there in ad-hoc manner. It would be cleaner to provide a > customization to add various cli tools in a defcustom/defvar without > manually changing the functions. > > 2. I feel like it will be hard to maintain such unpopular clients. If > (1) is addressed + good automatic tests are implemented, things may > be acceptable for inclusion though. > > In summary, I am not against the idea of including a new sql cli, but we > should better provide a centralized API to do so and make sure that we > have test coverage, making sure that things are not broken in future, > when the original committer is gone and nobody else is left familiar > with specific obscure SQL client. I think you run a high risk of running into GNU policy issues wrt licensing and free software support given this is a cleint for an AWS only database.