emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Pan Xie <xiepan@skyguard.com.cn>
To: emacs-orgmode@gnu.org
Subject: org-goto bug
Date: Thu, 22 Feb 2024 15:40:25 +0800	[thread overview]
Message-ID: <5f491471-af08-49d5-a840-6b2f96be54cf@skyguard.com.cn> (raw)

Hello

Just found a minor issue about the org-goto interface. When I set 
`org-goto-auto-isearch' as `t', the number keys should also be part of 
isearch, not treated as "digit argument". However, the current version 
(9.7-pre) of OrgMode I am using treat the number keys as digit argument 
in auto isearch mode.

I also find the solution: just pass `t' as second argument to 
`suppress-keymap', to make all number keys unbound in the keymap:

#+begin_src elisp
;; org-goto.el
(defun org-goto--set-map ()
   "Set the keymap `org-goto'."
   (setq org-goto-map
     (let ((map (make-sparse-keymap)))
       (let ((cmds '(isearch-forward isearch-backward kill-ring-save 
set-mark-command
                     mouse-drag-region universal-argument org-occur)))
         (dolist (cmd cmds)
           (substitute-key-definition cmd cmd map global-map)))
       (suppress-keymap map t) ;; <==================================== 
pass t as second argument to fix the issue
       (org-defkey map "\C-m"     'org-goto-ret)
       (org-defkey map [(return)] 'org-goto-ret)

#+end_src

The version of org-mode with the issue:

#+begin_src elisp
   (org-version nil t)
   ;;=> "Org mode version 9.7-pre (release_9.6.19-1208-g7360c6 @ 
/home/git/org-mode/lisp/)"
#+end_src

next             reply	other threads:[~2024-02-22  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  7:40 Pan Xie [this message]
2024-02-24  9:09 ` org-goto bug Ihor Radchenko
  -- strict thread matches above, loose matches on Subject: below --
2012-12-31 16:09 Tyler Smith
2013-01-02  9:49 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f491471-af08-49d5-a840-6b2f96be54cf@skyguard.com.cn \
    --to=xiepan@skyguard.com.cn \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).