From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qGCiJ161jmDoAQEAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 16:21:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mHAfI161jmCRTgAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 14:21:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF6B825F43 for ; Sun, 2 May 2021 16:21:17 +0200 (CEST) Received: from localhost ([::1]:34550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldCyB-0003UR-TL for larch@yhetil.org; Sun, 02 May 2021 10:21:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldCxY-0003Tj-88 for emacs-orgmode@gnu.org; Sun, 02 May 2021 10:20:36 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldCxW-00076r-7o for emacs-orgmode@gnu.org; Sun, 02 May 2021 10:20:36 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 102005C0135 for ; Sun, 2 May 2021 10:20:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 02 May 2021 10:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=st0I8V swvYM7YfZyO5QCm6d+2680g5aYos6aZo/L9W8=; b=f77NWDmAmExbDihraLtK9Q XogewleTX4d6yTubaG297EhYr4+UvtrQ0MBYkEfHiK1EQM3kU9+LA+k1+Zb1BXiV /8RoRB8ZK8OWRi+Won74g4CTzqj8DU9Bni6ve0AyqoqEQyKQuqfIzEt39caC1fEf xewdOIrYXgg+oR5HA2q8QOQu7WRD2Nb8qpmZDA4AQSUwgCsxhBBknv0wk3+fAweh IjiB2e2jzR2jNvuPRPyTn+94Unk/u9FwgAMdiZBiJIRok3GXN5Ic+WHzBgNJyf9N E54SH3D6d1JA+I7Ovc8IBHBx0ph8KXU12FASGm5NFOpPoBnmTKCxAITLD0h9qAsQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefuddguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepvfhfuffhkffffgggjggtsehmtd erredtfeejnecuhfhrohhmpefpihgtkhcuufgrvhgrghgvuceonhhitghksehnihgtkhhs rghvrghgvgdrtggrqeenucggtffrrghtthgvrhhnpeeugeevjeeiveeijeejvdehgfejgf efkeffhfetudfgteetleetleduueektdffheenucffohhmrghinhepohhrghhmohguvgdr ohhrghdpohgttghurhdrohhrghenucfkphepudejgedrleefrdduieehrddufeenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihgtkhesnhhi tghkshgrvhgrghgvrdgtrg X-ME-Proxy: Received: from [192.168.0.67] (bras-base-aylmpq0104w-grc-46-174-93-165-13.dsl.bell.ca [174.93.165.13]) by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 2 May 2021 10:20:31 -0400 (EDT) To: emacs-orgmode@gnu.org References: <875z02si3g.fsf@nicolasgoaziou.fr> Subject: [PATCH]: org-columns does not respect global-visual-line-mode for long text within headlines From: Nick Savage Message-ID: <5b9ffb77-5945-b045-dec1-4613ba9398d3@nicksavage.ca> Date: Sun, 2 May 2021 10:20:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <875z02si3g.fsf@nicolasgoaziou.fr> Content-Type: multipart/mixed; boundary="------------5A1BB1ED3F1390A95BEB2EC6" Content-Language: en-US Received-SPF: none client-ip=66.111.4.26; envelope-from=nick@nicksavage.ca; helo=out2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619965278; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=st0I8VswvYM7YfZyO5QCm6d+2680g5aYos6aZo/L9W8=; b=lSdnBkLy5EmgE8p15aI8wWaJjRd058cQg93b7tsuhHeU5hvdxrl6rHzX1x34ijz9+ad75E jVmKvCFPXecCyzYw5lM0snTg6IUGk5ESY5lSslW+SpY+2jL62xdszxRLNTtCM/bIs6zr0D N3Y5G/Urt7Oy3DPpOo3DD+TFJ47VoMqLD0B69uLTM0miykv5+ep4m+ioIdEPLXj+3hl38V gdd1WlKLFbRSCBRumuQ8Jllaoexr5GXQAQy31rYLlV4l2A2vx013jO9sli8sNKTsZvTcOY Xo0p3JkDuFgeximn3p3hDd1NaIT7NLe1JF+eZWpMhBd/dJG/PI30wKK8THOwMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619965278; a=rsa-sha256; cv=none; b=rhApWRLqpxog7bcbcOdas4GQ9MkbcH3KLYrhH/qkEFIdFTHn0lV+q+Y8WxXLD1K/kQKnlY d0ZFt8X/vpJYA+kzgJ8CxhRruSUeprByx7nOmTe+3WIwYIZwjNwqlqK5E67VD152SA4LV3 As55i3JxCzpJm4nnK3+m8rAKWMz1xJS5h4m6DYzmni7/Ah6Q1GP/EJYQ4p4AhDrpU73gMV q+5fV8ERzs2IRYT2kfnQJ9TbgeIdolQcQeOtoyAIRZg1Sla0rhgeb82C7ukXb37loBU/vL JhA/lru6Rgk1B0ENcqBP5F6K/fqFmmCcZheRm4LfUuUi5JYEnaGI8xxssVJJdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=f77NWDmA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=f77NWDmA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BF6B825F43 X-Spam-Score: -1.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: zm+FHhou229V This is a multi-part message in MIME format. --------------5A1BB1ED3F1390A95BEB2EC6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I've done some more research on https://orgmode.org/list/875z02si3g.fsf@nicolasgoaziou.fr/, and I believe the issue is that `org-columns' is setting `truncate-lines' as t, while `global-visual-line-mode' is expecting it to be set to nil. The interaction between the two causes the wrapping to not occur. `org-columns; also cleans up after itself and replaces truncate-lines with the original value, which is why the problem only occurs when `org-columns' is enabled it. The attached patch ensures the behaviour is correct when `global-visual-line-mode' is enabled and that there are no behaviour changes when it has not already been enabled. --------------5A1BB1ED3F1390A95BEB2EC6 Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-org-colview.el-Update-org-columns-to-respect-gl.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-org-colview.el-Update-org-columns-to-respect-gl.pa"; filename*1="tch" >From fbb91ddc2bc8b6f29651e3114754bcd8fcad30d0 Mon Sep 17 00:00:00 2001 From: Nicholas Savage Date: Sat, 1 May 2021 20:05:09 -0400 Subject: [PATCH] lisp/org-colview.el: Update org-columns to respect global-visual-line-mode * lisp/org-colview.el (org-columns): Prevent enabling truncate-lines when global-visual-line-mode is also enabled Fixing a bug where org-column overlays were disabling wrapping of lines when global-visual-line-mode was already activated, and so therefore expectation was that the lines would continue wrapping. This is because org-columns was setting truncate-lines to t, when global-visual-line-mode requires it to be set to nil. The interaction between the two caused the wrapping not to occur. --- lisp/org-colview.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index 517bcdf1c..9dad8c7d9 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -879,7 +879,8 @@ When COLUMNS-FMT-STRING is non-nil, use it as the column format." (unless (local-variable-p 'org-colview-initial-truncate-line-value) (setq-local org-colview-initial-truncate-line-value truncate-lines)) - (setq truncate-lines t) + (if (not global-visual-line-mode) + (setq truncate-lines t)) (dolist (entry cache) (goto-char (car entry)) (org-columns--display-here (cdr entry))))))))) -- 2.20.1 --------------5A1BB1ED3F1390A95BEB2EC6--