Re: Release: Org-mode 5.09

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Levin <zslevin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Release: Org-mode 5.09
Date: Tue, 18 Sep 2007 12:59:40 +0200	[thread overview]
Message-ID: <572452f66890dd8ebca04908cbd33e29@gmail.com> (raw)
In-Reply-To: <200709181700.17786.zslevin@gmail.com>

On Sep 18, 2007, at 11:00, Levin wrote:

> Hi Carsten,
>
>>    - Priority cycling goes back to the nil state.
>
> Priority cycling is a bit odd. When I use M-n to cycle, it turns
> from #C-> nil-> #C-> nil, and M-p will be #A->nil->#A->nil.

I did it like this on purpose, because I wanted S-up to
immediately increase the priority.  The default priority is
#B.  I know this works differently from the other cycling mechanisms
in Org.  However, with you implementation you need to press

S-up S-up S-up to finally get to #A, or you oddly need to use S-down(!)
in increase the priority.  I can see argument for both, open to 
discussion!

- Carsten

>
> So I write this small patch to achieve: M-n will cycle from
> #A->#B->#C->nil->#A, and M-p will cycle from #C->#B->#A->nil->#C.
>
> Hope it helps.
>
> -Levin
>
> ;; This patch is against org 5.09
>
> diff --git a/lisp/org/org.el b/lisp/org/org.el
> index f4746b4..a5567f5 100644
> --- a/lisp/org/org.el
> +++ b/lisp/org/org.el
> @@ -13462,7 +13462,11 @@ ACTION can be `set', `up', `down', or a 
> character."
>        (if (looking-at org-priority-regexp)
>  	  (setq current (string-to-char (match-string 2))
>  		have t)
> -	(setq current org-default-priority))
> +	(setq current (if (eq action 'up)
> +			  (1+ org-lowest-priority)
> +			(if (eq action 'down)
> +			    (1- org-highest-priority)
> +			  org-default-priority))))
>        (cond
>         ((or (eq action 'set) (integerp action))
>  	(if (integerp action)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477