From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Banel Subject: Re: Add caching to org-buffer-property-keys Date: Wed, 02 Mar 2016 19:48:52 +0100 Message-ID: <56D73594.6090908@free.fr> References: <2016-03-02T12-21-52@devnull.Karl-Voit.at> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abBpT-00027C-SK for emacs-orgmode@gnu.org; Wed, 02 Mar 2016 13:49:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abBpP-0006xK-Sv for emacs-orgmode@gnu.org; Wed, 02 Mar 2016 13:48:59 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:53427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abBpP-0006wx-LV for emacs-orgmode@gnu.org; Wed, 02 Mar 2016 13:48:55 -0500 Received: from [IPv6:2a01:e35:2e21:def0:a968:7355:18ba:9bb4] (unknown [IPv6:2a01:e35:2e21:def0:a968:7355:18ba:9bb4]) by smtp4-g21.free.fr (Postfix) with ESMTP id D771D4C80DC for ; Wed, 2 Mar 2016 19:45:51 +0100 (CET) In-Reply-To: <2016-03-02T12-21-52@devnull.Karl-Voit.at> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nice function! Maybe a rewrite of (org-read-property-name) calling (org-entry-properties) could speed up things. (org-entry-properties) returns an assoc list of the local header properti= es. Le 02/03/2016 12:29, Karl Voit a =E9crit : > Hi! > > In short: can we get a cached org-buffer-property-keys please? > > > My background story: > > I love using following function which gives me a neat functionality: > I mark a string, press the keybinding shortcut, and gets asked which > property should be replaced/filled with the marked region text. > > Very handy when you've got a new phone number of a contact which > should find its way to the associated property. > > (defun my-org-region-to-property (&optional property) > (interactive) > ;; if no region is defined, do nothing > (if (use-region-p) > ;; if a region string is found, ask for a property and set proper= ty to > ;; the string in the region > (let ((val (replace-regexp-in-string > "\\`[ \t\n]*" "" > (replace-regexp-in-string "[ \t\n]*\\'" "" > (substring (buffer-string) > (- (region-begin= ning) 1) > (region-end)))) > ) > ;; if none was stated by user, read property from user > (prop (or property > (org-read-property-name)))) > ;; set property > (org-set-property prop val)))) > > A big drawback is that I have to wait 18 seconds(!) until > org-read-property-name which calls org-buffer-property-keys asks for > the property. This is a real show stopper for this cool function. > > Since the properties of a buffer do not change that often, caching > its previous result would make sense to me. This way, I only have to > wait 18 seconds once per file on the first call. > > An alternative would be a org-read-property-name which uses only the > properties of the current heading. > > > Thanks for your support! >