From: Erik Hetzner <egh@e6h.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-attach.el: Fetch attachments from git annex
Date: Tue, 05 Jan 2016 17:15:21 -0800 [thread overview]
Message-ID: <568c6aaa.c345620a.7f4da.6359@mx.google.com> (raw)
In-Reply-To: <87poxg8s22.fsf@kyleam.com>
Thanks for the feedback, Kyle! I will make these changes and resubmit.
And thanks for the pointer to =git annex find PATH=. I think I can use that to
check if a file needs to be fetched.
(more below)
On Mon, 04 Jan 2016 22:21:41 -0800,
Kyle Meyer <kyle@kyleam.com> wrote:
>
> Thanks for the patch.
>
> […]
>
> > + (org-attach-use-annex)
> > + (not (file-exists-p (file-symlink-p path))))
> > + (call-process "git" nil nil nil "annex" "get" path))
>
> - Should this display a message before calling "git annex get" to let the
> user know what's happening in case fetching the file takes some time?
That would make sense. I’ll change it.
> - Should there be a setting the controls whether attachments are
> automatically fetched?
I don’t see why. If a file is managed in git annex and the user is trying to
open it, I can’t imagine why they wouldn’t want it fetched.
best, Erik
--
Sent from my free software system <http://fsf.org/>.
next prev parent reply other threads:[~2016-01-06 1:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 5:09 [PATCH] org-attach.el: Fetch attachments from git annex Erik Hetzner
2016-01-05 5:30 ` Eric Abrahamsen
2016-01-05 6:11 ` Erik Hetzner
2016-01-05 6:36 ` Kyle Meyer
2016-01-05 9:56 ` Rasmus
2016-01-05 17:14 ` Kyle Meyer
2016-01-05 18:16 ` Rasmus
2016-01-05 19:30 ` Kyle Meyer
2016-01-05 21:55 ` Rasmus
2016-01-06 5:43 ` Kyle Meyer
2016-01-06 1:27 ` Erik Hetzner
2016-01-06 9:37 ` Rasmus
2016-01-05 6:21 ` Kyle Meyer
2016-01-06 1:15 ` Erik Hetzner [this message]
2016-01-25 5:24 ` Erik Hetzner
2016-01-25 21:19 ` Rasmus
2016-01-25 4:34 ` Erik Hetzner
2016-01-26 7:40 ` Kyle Meyer
2016-01-26 16:39 ` Erik Hetzner
2016-01-26 17:34 ` Kyle Meyer
2016-01-26 22:04 ` Rasmus
2016-01-25 4:34 ` [PATCH] org-attach.el: Get " Erik Hetzner
2016-01-27 22:20 ` Rasmus
2016-02-01 3:32 ` Erik Hetzner
2016-01-29 5:39 ` Kyle Meyer
2016-01-25 4:34 ` Erik Hetzner
2016-02-05 2:41 ` Kyle Meyer
2016-02-06 12:18 ` Rasmus
2016-02-07 17:15 ` Erik Hetzner
2016-02-07 20:48 ` Achim Gratz
2016-02-09 5:25 ` Erik Hetzner
2016-02-09 19:40 ` Achim Gratz
2016-02-09 21:12 ` Erik Hetzner
2016-02-09 22:19 ` Achim Gratz
2016-02-11 2:24 ` Erik Hetzner
2016-02-11 18:57 ` Achim Gratz
2016-02-09 5:40 ` [PATCH] testing/lisp/test-org-attach-annex.el: New file Erik Hetzner
2016-02-14 11:50 ` Achim Gratz
2016-01-26 5:31 ` [PATCH] org-attach.el: Fetch attachments from git annex Erik Hetzner
2016-01-26 22:10 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568c6aaa.c345620a.7f4da.6359@mx.google.com \
--to=egh@e6h.org \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).