From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Martelli Subject: Re: org-protocol documentation Date: Fri, 23 Jun 2017 18:46:14 +0200 Message-ID: <5442AC7A-D45E-46FE-A3A7-3AB25679B3FE@schnuddelhuddel.de> References: <68E12968-9AF5-440A-B22C-AC55B70BA910@schnuddelhuddel.de> <87k248b6p8.fsf@nicolasgoaziou.fr> <7C76EDC3-CC7E-4AFE-B45B-867752C1B33A@schnuddelhuddel.de> <87a8519rlg.fsf@nicolasgoaziou.fr> <8760fp9mui.fsf@nicolasgoaziou.fr> <2FAD7DF2-2A0C-4703-A383-BA8D3346C691@schnuddelhuddel.de> <18D83D3C-C472-4614-988F-1F1DA5EB5CEC@schnuddelhuddel.de> <87efub7psj.fsf@nicolasgoaziou.fr> <8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dORiv-0007iH-OX for emacs-orgmode@gnu.org; Fri, 23 Jun 2017 12:46:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dORis-0002Eb-Lg for emacs-orgmode@gnu.org; Fri, 23 Jun 2017 12:46:21 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:36402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dORis-0002ED-Dr for emacs-orgmode@gnu.org; Fri, 23 Jun 2017 12:46:18 -0400 Received: by mail-wr0-x244.google.com with SMTP id 77so13800943wrb.3 for ; Fri, 23 Jun 2017 09:46:18 -0700 (PDT) In-Reply-To: <8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Hi, > fails all the time causing the function to fail silently. I got "open-source" working by sanitising the URI before it is = processed. diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el index 825435674..7e986a9ed 100644 --- a/lisp/org-protocol.el +++ b/lisp/org-protocol.el @@ -520,7 +520,7 @@ The location for a browser's bookmark should look = like this: ;; As we enter this function for a match on our protocol, the return = value ;; defaults to nil. (let ((result nil) - (f (plist-get (org-protocol-parse-parameters fname nil '(:url)) = :url))) + (f (org-protocol-sanitize-uri (plist-get = (org-protocol-parse-parameters fname nil '(:url)) :url)))) (catch 'result (dolist (prolist org-protocol-project-alist) (let* ((base-url (plist-get (cdr prolist) :base-url)) Unfortunately it is still failing for old-style URIs. Fixing that would = exceed my abilities. I could document that "open-source" does only support new-style URIs. = Not sure if that is the best solution. Kind regards Mario =E2=80=94=20